-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-7907] [SQL] [UI] Rename tab ThriftServer to SQL. #6448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor - but should this read "JDBC Server" with a space?
|
LGTM - minor suggestion to add a space here in the presentation. |
|
After some more thought I was thinking maybe:
|
|
My only concern is that, the Thrift server can be also used with ODBC, so "JDBC server" doesn't seem to be an accurate name? |
|
Test build #33626 has finished for PR 6448 at commit
|
|
LGTM, I think |
|
Test build #33634 has finished for PR 6448 at commit
|
|
Thanks for comments and review! I am merging it to branch 1.4 and master. |
This PR has three changes: 1. Renaming the table of `ThriftServer` to `SQL`; 2. Renaming the title of the tab from `ThriftServer` to `JDBC/ODBC Server`; and 3. Renaming the title of the session page from `ThriftServer` to `JDBC/ODBC Session`. https://issues.apache.org/jira/browse/SPARK-7907 Author: Yin Huai <[email protected]> Closes #6448 from yhuai/JDBCServer and squashes the following commits: eadcc3d [Yin Huai] Update test. 9168005 [Yin Huai] Use SQL as the tab name. 221831e [Yin Huai] Rename ThriftServer to JDBCServer. (cherry picked from commit 3c1f1ba) Signed-off-by: Yin Huai <[email protected]>
|
Seems weird to me that the script to start the server and the tab in the UI
|
This PR has three changes: 1. Renaming the table of `ThriftServer` to `SQL`; 2. Renaming the title of the tab from `ThriftServer` to `JDBC/ODBC Server`; and 3. Renaming the title of the session page from `ThriftServer` to `JDBC/ODBC Session`. https://issues.apache.org/jira/browse/SPARK-7907 Author: Yin Huai <[email protected]> Closes apache#6448 from yhuai/JDBCServer and squashes the following commits: eadcc3d [Yin Huai] Update test. 9168005 [Yin Huai] Use SQL as the tab name. 221831e [Yin Huai] Rename ThriftServer to JDBCServer.
This PR has three changes: 1. Renaming the table of `ThriftServer` to `SQL`; 2. Renaming the title of the tab from `ThriftServer` to `JDBC/ODBC Server`; and 3. Renaming the title of the session page from `ThriftServer` to `JDBC/ODBC Session`. https://issues.apache.org/jira/browse/SPARK-7907 Author: Yin Huai <[email protected]> Closes apache#6448 from yhuai/JDBCServer and squashes the following commits: eadcc3d [Yin Huai] Update test. 9168005 [Yin Huai] Use SQL as the tab name. 221831e [Yin Huai] Rename ThriftServer to JDBCServer.
This PR has three changes:
ThriftServertoSQL;ThriftServertoJDBC/ODBC Server; andThriftServertoJDBC/ODBC Session.https://issues.apache.org/jira/browse/SPARK-7907