Skip to content

Conversation

@yhuai
Copy link
Contributor

@yhuai yhuai commented May 27, 2015

This PR has three changes:

  1. Renaming the table of ThriftServer to SQL;
  2. Renaming the title of the tab from ThriftServer to JDBC/ODBC Server; and
  3. Renaming the title of the session page from ThriftServer to JDBC/ODBC Session.

https://issues.apache.org/jira/browse/SPARK-7907

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor - but should this read "JDBC Server" with a space?

@pwendell
Copy link
Contributor

LGTM - minor suggestion to add a space here in the presentation.

@pwendell
Copy link
Contributor

After some more thought I was thinking maybe:

  1. Have the top level tab be SQL.
  2. Have the section title say "JDBC/ODBC Server"

@liancheng
Copy link
Contributor

My only concern is that, the Thrift server can be also used with ODBC, so "JDBC server" doesn't seem to be an accurate name?

@yhuai yhuai changed the title [SPARK-7907] [SQL] Rename ThriftServer to JDBCServer. [SPARK-7907] [SQL] [UI] Rename ThriftServer to SQL. May 28, 2015
@yhuai yhuai changed the title [SPARK-7907] [SQL] [UI] Rename ThriftServer to SQL. [SPARK-7907] [SQL] [UI] Rename tab ThriftServer to SQL. May 28, 2015
@SparkQA
Copy link

SparkQA commented May 28, 2015

Test build #33626 has finished for PR 6448 at commit 221831e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

LGTM, I think JDBC/ODBC Server is the most descriptive and concise title.

@SparkQA
Copy link

SparkQA commented May 28, 2015

Test build #33634 has finished for PR 6448 at commit eadcc3d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor Author

yhuai commented May 28, 2015

Thanks for comments and review! I am merging it to branch 1.4 and master.

asfgit pushed a commit that referenced this pull request May 28, 2015
This PR has three changes:
1. Renaming the table of `ThriftServer` to `SQL`;
2. Renaming the title of the tab from `ThriftServer` to `JDBC/ODBC Server`; and
3. Renaming the title of the session page from `ThriftServer` to `JDBC/ODBC Session`.

https://issues.apache.org/jira/browse/SPARK-7907

Author: Yin Huai <[email protected]>

Closes #6448 from yhuai/JDBCServer and squashes the following commits:

eadcc3d [Yin Huai] Update test.
9168005 [Yin Huai] Use SQL as the tab name.
221831e [Yin Huai] Rename ThriftServer to JDBCServer.

(cherry picked from commit 3c1f1ba)
Signed-off-by: Yin Huai <[email protected]>
@asfgit asfgit closed this in 3c1f1ba May 28, 2015
@marmbrus
Copy link
Contributor

Seems weird to me that the script to start the server and the tab in the UI
have different names now.
On May 28, 2015 11:17 AM, "UCB AMPLab" [email protected] wrote:

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33632/
Test FAILed.


Reply to this email directly or view it on GitHub
#6448 (comment).

jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
This PR has three changes:
1. Renaming the table of `ThriftServer` to `SQL`;
2. Renaming the title of the tab from `ThriftServer` to `JDBC/ODBC Server`; and
3. Renaming the title of the session page from `ThriftServer` to `JDBC/ODBC Session`.

https://issues.apache.org/jira/browse/SPARK-7907

Author: Yin Huai <[email protected]>

Closes apache#6448 from yhuai/JDBCServer and squashes the following commits:

eadcc3d [Yin Huai] Update test.
9168005 [Yin Huai] Use SQL as the tab name.
221831e [Yin Huai] Rename ThriftServer to JDBCServer.
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
This PR has three changes:
1. Renaming the table of `ThriftServer` to `SQL`;
2. Renaming the title of the tab from `ThriftServer` to `JDBC/ODBC Server`; and
3. Renaming the title of the session page from `ThriftServer` to `JDBC/ODBC Session`.

https://issues.apache.org/jira/browse/SPARK-7907

Author: Yin Huai <[email protected]>

Closes apache#6448 from yhuai/JDBCServer and squashes the following commits:

eadcc3d [Yin Huai] Update test.
9168005 [Yin Huai] Use SQL as the tab name.
221831e [Yin Huai] Rename ThriftServer to JDBCServer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants