[SPARK-7859] [SQL] Collect_set() behavior differences which fails the unit test under jdk8 #6402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @yhuai |
Contributor
|
Thanks for investigating this! Instead of just checking the size, can we modify the query to use |
|
Test build #33493 has finished for PR 6402 at commit
|
Contributor
Author
|
Yes, that's a good suggestion, I've updated the code. |
|
Test build #33502 has finished for PR 6402 at commit
|
|
Test build #33503 has finished for PR 6402 at commit
|
Contributor
Author
|
@yhuai since it's will not tested under the jdk8 by jenkins, I've manually tested it in my local, and it passed, can you also verify that if you got time? |
Contributor
|
test this please. |
Contributor
|
LGTM pending jenkins. |
|
Test build #35494 has finished for PR 6402 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Jun 23, 2015
… unit test under jdk8 To reproduce that: ``` JAVA_HOME=/home/hcheng/Java/jdk1.8.0_45 | build/sbt -Phadoop-2.3 -Phive 'test-only org.apache.spark.sql.hive.execution.HiveWindowFunctionQueryWithoutCodeGenSuite' ``` A simple workaround to fix that is update the original query, for getting the output size instead of the exact elements of the array (output by collect_set()) Author: Cheng Hao <[email protected]> Closes #6402 from chenghao-intel/windowing and squashes the following commits: 99312ad [Cheng Hao] add order by for the select clause edf8ce3 [Cheng Hao] update the code as suggested 7062da7 [Cheng Hao] fix the collect_set() behaviour differences under different versions of JDK (cherry picked from commit 13321e6) Signed-off-by: Yin Huai <[email protected]>
Contributor
|
Thanks. I have merged it to master and branch 1.4. |
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 25, 2015
… unit test under jdk8 To reproduce that: ``` JAVA_HOME=/home/hcheng/Java/jdk1.8.0_45 | build/sbt -Phadoop-2.3 -Phive 'test-only org.apache.spark.sql.hive.execution.HiveWindowFunctionQueryWithoutCodeGenSuite' ``` A simple workaround to fix that is update the original query, for getting the output size instead of the exact elements of the array (output by collect_set()) Author: Cheng Hao <[email protected]> Closes apache#6402 from chenghao-intel/windowing and squashes the following commits: 99312ad [Cheng Hao] add order by for the select clause edf8ce3 [Cheng Hao] update the code as suggested 7062da7 [Cheng Hao] fix the collect_set() behaviour differences under different versions of JDK (cherry picked from commit 13321e6) Signed-off-by: Yin Huai <[email protected]>
animeshbaranawal
pushed a commit
to animeshbaranawal/spark
that referenced
this pull request
Jun 25, 2015
… unit test under jdk8 To reproduce that: ``` JAVA_HOME=/home/hcheng/Java/jdk1.8.0_45 | build/sbt -Phadoop-2.3 -Phive 'test-only org.apache.spark.sql.hive.execution.HiveWindowFunctionQueryWithoutCodeGenSuite' ``` A simple workaround to fix that is update the original query, for getting the output size instead of the exact elements of the array (output by collect_set()) Author: Cheng Hao <[email protected]> Closes apache#6402 from chenghao-intel/windowing and squashes the following commits: 99312ad [Cheng Hao] add order by for the select clause edf8ce3 [Cheng Hao] update the code as suggested 7062da7 [Cheng Hao] fix the collect_set() behaviour differences under different versions of JDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce that:
A simple workaround to fix that is update the original query, for getting the output size instead of the exact elements of the array (output by collect_set())