Skip to content

[SPARK-7639] [PySpark] [MLlib] Python API for KernelDensity #6387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[SPARK-7639] [PySpark] [MLlib] Python API for KernelDensity #6387

wants to merge 4 commits into from

Conversation

@MechCoder
Copy link
Contributor

@MechCoder MechCoder commented May 24, 2015

Python API for KernelDensity

@MechCoder
Copy link
Contributor Author

MechCoder commented May 24, 2015

Will add tests as soon as #6383 is resolved (or) merged.

cc @mengxr

@SparkQA
Copy link

SparkQA commented May 24, 2015

Test build #33433 has finished for PR 6387 at commit 4d88d59.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KernelDensity(object):

@mengxr mengxr mentioned this pull request May 26, 2015
Closed
mengxr
mengxr reviewed May 26, 2015
View reviewed changes
python/pyspark/mllib/stat/KernelDensity.py Outdated
Copy link
Contributor

@mengxr mengxr May 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default should be None.

@MechCoder MechCoder force-pushed the spark-7639 branch 2 times, most recently from 503dd92 to 324f60f Compare May 27, 2015 06:55
@MechCoder
Copy link
Contributor Author

MechCoder commented May 27, 2015

@mengxr done!

@SparkQA
Copy link

SparkQA commented May 27, 2015

Test build #33569 has finished for PR 6387 at commit 324f60f.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KernelDensity(object):

@SparkQA
Copy link

SparkQA commented May 27, 2015

Test build #33572 has finished for PR 6387 at commit 05c5da7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KernelDensity(object):

@mengxr
Copy link
Contributor

mengxr commented May 27, 2015

@MechCoder Python doctests are not automatically discovered. We have to include them manually. See: https://github.com/apache/spark/blob/master/python/run-tests#L93. Please include KernelDensity there and let Jenkins test against different Python versions.

@MechCoder
Copy link
Contributor Author

MechCoder commented May 28, 2015

@mengxr done !

@SparkQA
Copy link

SparkQA commented May 28, 2015

Test build #33640 has finished for PR 6387 at commit e99d979.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KernelDensity(object):

@mengxr
Copy link
Contributor

mengxr commented May 28, 2015

LGTM (I'm going to merge this after 1.4.)

@SparkQA
Copy link

SparkQA commented Jun 5, 2015

Test build #34295 has finished for PR 6387 at commit 17abc62.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KernelDensity(object):

@mengxr
Copy link
Contributor

mengxr commented Jun 6, 2015

Merged into master. Thanks!

MechCoder added a commit that referenced this pull request Jun 6, 2015
@MechCoder @mengxr
[SPARK-7639] [PYSPARK] [MLLIB] Python API for KernelDensity
5aa804f 
Python API for KernelDensity

Author: MechCoder <[email protected]>

Closes #6387 from MechCoder/spark-7639 and squashes the following commits:

17abc62 [MechCoder] add tests
2de6540 [MechCoder] style tests
bf4acc0 [MechCoder] Added doctests
84359d5 [MechCoder] [SPARK-7639] Python API for KernelDensity
@MechCoder MechCoder closed this Jun 7, 2015
@MechCoder MechCoder deleted the spark-7639 branch June 7, 2015 05:56
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@MechCoder @nemccarthy
[SPARK-7639] [PYSPARK] [MLLIB] Python API for KernelDensity
8a51aaf 
Python API for KernelDensity

Author: MechCoder <[email protected]>

Closes apache#6387 from MechCoder/spark-7639 and squashes the following commits:

17abc62 [MechCoder] add tests
2de6540 [MechCoder] style tests
bf4acc0 [MechCoder] Added doctests
84359d5 [MechCoder] [SPARK-7639] Python API for KernelDensity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MechCoder @SparkQA @mengxr