-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SQL] SPARK-6981: Factor out SparkPlanner and QueryExecution from SQLContext #6356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b087770
Refactor out QueryExecution, SparkPlanner
evacchi c22aa54
Move QueryExecution, SparkPlanner to execution package
evacchi b01244b
Ported to Spark 1.5
evacchi 253c15e
Fix scala style
evacchi 0089435
Fix merge conflicts
evacchi 24819e5
SparkPlanner: Re-align imports to master
evacchi 3bf710b
Merge branch 'master' into sqlctx-refactoring-lite
evacchi 47685cc
Update SQLContext.scala
evacchi 22a01ae
Scala style
evacchi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,6 +38,10 @@ import org.apache.spark.sql.catalyst.optimizer.{DefaultOptimizer, Optimizer} | |
| import org.apache.spark.sql.catalyst.plans.logical.{LocalRelation, LogicalPlan} | ||
| import org.apache.spark.sql.catalyst.rules.RuleExecutor | ||
| import org.apache.spark.sql.catalyst.{InternalRow, ParserDialect, _} | ||
| import org.apache.spark.sql.execution.{Filter, _} | ||
| import org.apache.spark.sql.{execution => sparkexecution} | ||
| import org.apache.spark.sql.execution._ | ||
| import org.apache.spark.sql.sources._ | ||
| import org.apache.spark.sql.execution._ | ||
| import org.apache.spark.sql.execution.datasources._ | ||
| import org.apache.spark.sql.execution.ui.{SQLListener, SQLTab} | ||
|
|
@@ -188,9 +192,11 @@ class SQLContext(@transient val sparkContext: SparkContext) | |
|
|
||
| protected[sql] def parseSql(sql: String): LogicalPlan = ddlParser.parse(sql, false) | ||
|
|
||
| protected[sql] def executeSql(sql: String): this.QueryExecution = executePlan(parseSql(sql)) | ||
| protected[sql] def executeSql(sql: String): | ||
| org.apache.spark.sql.execution.QueryExecution = executePlan(parseSql(sql)) | ||
|
|
||
| protected[sql] def executePlan(plan: LogicalPlan) = new this.QueryExecution(plan) | ||
| protected[sql] def executePlan(plan: LogicalPlan) = | ||
| new sparkexecution.QueryExecution(this, plan) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd consider just spelling this out instead of using an aliased package to make it a little easier to follow. |
||
|
|
||
| @transient | ||
| protected[sql] val tlSession = new ThreadLocal[SQLSession]() { | ||
|
|
@@ -781,77 +787,11 @@ class SQLContext(@transient val sparkContext: SparkContext) | |
| }.toArray | ||
| } | ||
|
|
||
| protected[sql] class SparkPlanner extends SparkStrategies { | ||
| val sparkContext: SparkContext = self.sparkContext | ||
|
|
||
| val sqlContext: SQLContext = self | ||
|
|
||
| def codegenEnabled: Boolean = self.conf.codegenEnabled | ||
|
|
||
| def unsafeEnabled: Boolean = self.conf.unsafeEnabled | ||
|
|
||
| def numPartitions: Int = self.conf.numShufflePartitions | ||
|
|
||
| def strategies: Seq[Strategy] = | ||
| experimental.extraStrategies ++ ( | ||
| DataSourceStrategy :: | ||
| DDLStrategy :: | ||
| TakeOrderedAndProject :: | ||
| HashAggregation :: | ||
| Aggregation :: | ||
| LeftSemiJoin :: | ||
| EquiJoinSelection :: | ||
| InMemoryScans :: | ||
| BasicOperators :: | ||
| CartesianProduct :: | ||
| BroadcastNestedLoopJoin :: Nil) | ||
|
|
||
| /** | ||
| * Used to build table scan operators where complex projection and filtering are done using | ||
| * separate physical operators. This function returns the given scan operator with Project and | ||
| * Filter nodes added only when needed. For example, a Project operator is only used when the | ||
| * final desired output requires complex expressions to be evaluated or when columns can be | ||
| * further eliminated out after filtering has been done. | ||
| * | ||
| * The `prunePushedDownFilters` parameter is used to remove those filters that can be optimized | ||
| * away by the filter pushdown optimization. | ||
| * | ||
| * The required attributes for both filtering and expression evaluation are passed to the | ||
| * provided `scanBuilder` function so that it can avoid unnecessary column materialization. | ||
| */ | ||
| def pruneFilterProject( | ||
| projectList: Seq[NamedExpression], | ||
| filterPredicates: Seq[Expression], | ||
| prunePushedDownFilters: Seq[Expression] => Seq[Expression], | ||
| scanBuilder: Seq[Attribute] => SparkPlan): SparkPlan = { | ||
|
|
||
| val projectSet = AttributeSet(projectList.flatMap(_.references)) | ||
| val filterSet = AttributeSet(filterPredicates.flatMap(_.references)) | ||
| val filterCondition = | ||
| prunePushedDownFilters(filterPredicates).reduceLeftOption(catalyst.expressions.And) | ||
|
|
||
| // Right now we still use a projection even if the only evaluation is applying an alias | ||
| // to a column. Since this is a no-op, it could be avoided. However, using this | ||
| // optimization with the current implementation would change the output schema. | ||
| // TODO: Decouple final output schema from expression evaluation so this copy can be | ||
| // avoided safely. | ||
|
|
||
| if (AttributeSet(projectList.map(_.toAttribute)) == projectSet && | ||
| filterSet.subsetOf(projectSet)) { | ||
| // When it is possible to just use column pruning to get the right projection and | ||
| // when the columns of this projection are enough to evaluate all filter conditions, | ||
| // just do a scan followed by a filter, with no extra project. | ||
| val scan = scanBuilder(projectList.asInstanceOf[Seq[Attribute]]) | ||
| filterCondition.map(Filter(_, scan)).getOrElse(scan) | ||
| } else { | ||
| val scan = scanBuilder((projectSet ++ filterSet).toSeq) | ||
| Project(projectList, filterCondition.map(Filter(_, scan)).getOrElse(scan)) | ||
| } | ||
| } | ||
| } | ||
| @deprecated("use org.apache.spark.sql.SparkPlanner", "1.6.0") | ||
| protected[sql] class SparkPlanner extends sparkexecution.SparkPlanner(this) | ||
|
|
||
| @transient | ||
| protected[sql] val planner = new SparkPlanner | ||
| protected[sql] val planner: sparkexecution.SparkPlanner = new sparkexecution.SparkPlanner(this) | ||
|
|
||
| @transient | ||
| protected[sql] lazy val emptyResult = sparkContext.parallelize(Seq.empty[InternalRow], 1) | ||
|
|
@@ -898,59 +838,9 @@ class SQLContext(@transient val sparkContext: SparkContext) | |
| protected[sql] lazy val conf: SQLConf = new SQLConf | ||
| } | ||
|
|
||
| /** | ||
| * :: DeveloperApi :: | ||
| * The primary workflow for executing relational queries using Spark. Designed to allow easy | ||
| * access to the intermediate phases of query execution for developers. | ||
| */ | ||
| @DeveloperApi | ||
| protected[sql] class QueryExecution(val logical: LogicalPlan) { | ||
| def assertAnalyzed(): Unit = analyzer.checkAnalysis(analyzed) | ||
|
|
||
| lazy val analyzed: LogicalPlan = analyzer.execute(logical) | ||
| lazy val withCachedData: LogicalPlan = { | ||
| assertAnalyzed() | ||
| cacheManager.useCachedData(analyzed) | ||
| } | ||
| lazy val optimizedPlan: LogicalPlan = optimizer.execute(withCachedData) | ||
|
|
||
| // TODO: Don't just pick the first one... | ||
| lazy val sparkPlan: SparkPlan = { | ||
| SparkPlan.currentContext.set(self) | ||
| planner.plan(optimizedPlan).next() | ||
| } | ||
| // executedPlan should not be used to initialize any SparkPlan. It should be | ||
| // only used for execution. | ||
| lazy val executedPlan: SparkPlan = prepareForExecution.execute(sparkPlan) | ||
|
|
||
| /** Internal version of the RDD. Avoids copies and has no schema */ | ||
| lazy val toRdd: RDD[InternalRow] = executedPlan.execute() | ||
|
|
||
| protected def stringOrError[A](f: => A): String = | ||
| try f.toString catch { case e: Throwable => e.toString } | ||
|
|
||
| def simpleString: String = | ||
| s"""== Physical Plan == | ||
| |${stringOrError(executedPlan)} | ||
| """.stripMargin.trim | ||
|
|
||
| override def toString: String = { | ||
| def output = | ||
| analyzed.output.map(o => s"${o.name}: ${o.dataType.simpleString}").mkString(", ") | ||
|
|
||
| s"""== Parsed Logical Plan == | ||
| |${stringOrError(logical)} | ||
| |== Analyzed Logical Plan == | ||
| |${stringOrError(output)} | ||
| |${stringOrError(analyzed)} | ||
| |== Optimized Logical Plan == | ||
| |${stringOrError(optimizedPlan)} | ||
| |== Physical Plan == | ||
| |${stringOrError(executedPlan)} | ||
| |Code Generation: ${stringOrError(executedPlan.codegenEnabled)} | ||
| """.stripMargin.trim | ||
| } | ||
| } | ||
| @deprecated("use org.apache.spark.sql.QueryExecution", "1.6.0") | ||
| protected[sql] class QueryExecution(logical: LogicalPlan) | ||
| extends sparkexecution.QueryExecution(this, logical) | ||
|
|
||
| /** | ||
| * Parses the data type in our internal string representation. The data type string should | ||
|
|
||
85 changes: 85 additions & 0 deletions
85
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.sql.execution | ||
|
|
||
| import org.apache.spark.annotation.{Experimental, DeveloperApi} | ||
| import org.apache.spark.rdd.RDD | ||
| import org.apache.spark.sql.catalyst.{InternalRow, optimizer} | ||
| import org.apache.spark.sql.{SQLContext, Row} | ||
| import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan | ||
|
|
||
| /** | ||
| * :: DeveloperApi :: | ||
| * The primary workflow for executing relational queries using Spark. Designed to allow easy | ||
| * access to the intermediate phases of query execution for developers. | ||
| */ | ||
| @DeveloperApi | ||
| class QueryExecution(val sqlContext: SQLContext, val logical: LogicalPlan) { | ||
| val analyzer = sqlContext.analyzer | ||
| val optimizer = sqlContext.optimizer | ||
| val planner = sqlContext.planner | ||
| val cacheManager = sqlContext.cacheManager | ||
| val prepareForExecution = sqlContext.prepareForExecution | ||
|
|
||
| def assertAnalyzed(): Unit = analyzer.checkAnalysis(analyzed) | ||
|
|
||
| lazy val analyzed: LogicalPlan = analyzer.execute(logical) | ||
| lazy val withCachedData: LogicalPlan = { | ||
| assertAnalyzed() | ||
| cacheManager.useCachedData(analyzed) | ||
| } | ||
| lazy val optimizedPlan: LogicalPlan = optimizer.execute(withCachedData) | ||
|
|
||
| // TODO: Don't just pick the first one... | ||
| lazy val sparkPlan: SparkPlan = { | ||
| SparkPlan.currentContext.set(sqlContext) | ||
| planner.plan(optimizedPlan).next() | ||
| } | ||
| // executedPlan should not be used to initialize any SparkPlan. It should be | ||
| // only used for execution. | ||
| lazy val executedPlan: SparkPlan = prepareForExecution.execute(sparkPlan) | ||
|
|
||
| /** Internal version of the RDD. Avoids copies and has no schema */ | ||
| lazy val toRdd: RDD[InternalRow] = executedPlan.execute() | ||
|
|
||
| protected def stringOrError[A](f: => A): String = | ||
| try f.toString catch { case e: Throwable => e.toString } | ||
|
|
||
| def simpleString: String = | ||
| s"""== Physical Plan == | ||
| |${stringOrError(executedPlan)} | ||
| """.stripMargin.trim | ||
|
|
||
|
|
||
| override def toString: String = { | ||
| def output = | ||
| analyzed.output.map(o => s"${o.name}: ${o.dataType.simpleString}").mkString(", ") | ||
|
|
||
| s"""== Parsed Logical Plan == | ||
| |${stringOrError(logical)} | ||
| |== Analyzed Logical Plan == | ||
| |${stringOrError(output)} | ||
| |${stringOrError(analyzed)} | ||
| |== Optimized Logical Plan == | ||
| |${stringOrError(optimizedPlan)} | ||
| |== Physical Plan == | ||
| |${stringOrError(executedPlan)} | ||
| |Code Generation: ${stringOrError(executedPlan.codegenEnabled)} | ||
| """.stripMargin.trim | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92 changes: 92 additions & 0 deletions
92
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlanner.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.sql.execution | ||
|
|
||
| import org.apache.spark.SparkContext | ||
| import org.apache.spark.annotation.Experimental | ||
| import org.apache.spark.sql._ | ||
| import org.apache.spark.sql.catalyst.expressions._ | ||
| import org.apache.spark.sql.execution.datasources.DataSourceStrategy | ||
|
|
||
| @Experimental | ||
| class SparkPlanner(val sqlContext: SQLContext) extends SparkStrategies { | ||
| val sparkContext: SparkContext = sqlContext.sparkContext | ||
|
|
||
| def codegenEnabled: Boolean = sqlContext.conf.codegenEnabled | ||
|
|
||
| def unsafeEnabled: Boolean = sqlContext.conf.unsafeEnabled | ||
|
|
||
| def numPartitions: Int = sqlContext.conf.numShufflePartitions | ||
|
|
||
| def strategies: Seq[Strategy] = | ||
| sqlContext.experimental.extraStrategies ++ ( | ||
| DataSourceStrategy :: | ||
| DDLStrategy :: | ||
| TakeOrderedAndProject :: | ||
| HashAggregation :: | ||
| Aggregation :: | ||
| LeftSemiJoin :: | ||
| EquiJoinSelection :: | ||
| InMemoryScans :: | ||
| BasicOperators :: | ||
| CartesianProduct :: | ||
| BroadcastNestedLoopJoin :: Nil) | ||
|
|
||
| /** | ||
| * Used to build table scan operators where complex projection and filtering are done using | ||
| * separate physical operators. This function returns the given scan operator with Project and | ||
| * Filter nodes added only when needed. For example, a Project operator is only used when the | ||
| * final desired output requires complex expressions to be evaluated or when columns can be | ||
| * further eliminated out after filtering has been done. | ||
| * | ||
| * The `prunePushedDownFilters` parameter is used to remove those filters that can be optimized | ||
| * away by the filter pushdown optimization. | ||
| * | ||
| * The required attributes for both filtering and expression evaluation are passed to the | ||
| * provided `scanBuilder` function so that it can avoid unnecessary column materialization. | ||
| */ | ||
| def pruneFilterProject( | ||
| projectList: Seq[NamedExpression], | ||
| filterPredicates: Seq[Expression], | ||
| prunePushedDownFilters: Seq[Expression] => Seq[Expression], | ||
| scanBuilder: Seq[Attribute] => SparkPlan): SparkPlan = { | ||
|
|
||
| val projectSet = AttributeSet(projectList.flatMap(_.references)) | ||
| val filterSet = AttributeSet(filterPredicates.flatMap(_.references)) | ||
| val filterCondition = | ||
| prunePushedDownFilters(filterPredicates).reduceLeftOption(catalyst.expressions.And) | ||
|
|
||
| // Right now we still use a projection even if the only evaluation is applying an alias | ||
| // to a column. Since this is a no-op, it could be avoided. However, using this | ||
| // optimization with the current implementation would change the output schema. | ||
| // TODO: Decouple final output schema from expression evaluation so this copy can be | ||
| // avoided safely. | ||
|
|
||
| if (AttributeSet(projectList.map(_.toAttribute)) == projectSet && | ||
| filterSet.subsetOf(projectSet)) { | ||
| // When it is possible to just use column pruning to get the right projection and | ||
| // when the columns of this projection are enough to evaluate all filter conditions, | ||
| // just do a scan followed by a filter, with no extra project. | ||
| val scan = scanBuilder(projectList.asInstanceOf[Seq[Attribute]]) | ||
| filterCondition.map(Filter(_, scan)).getOrElse(scan) | ||
| } else { | ||
| val scan = scanBuilder((projectSet ++ filterSet).toSeq) | ||
| Project(projectList, filterCondition.map(Filter(_, scan)).getOrElse(scan)) | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marmbrus This changes the signature of
queryExecution. Is there anyway that we can preserve the binary compatibility?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we preserve binary compatibility for developer API? At least MIMA doesn't complain about it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QueryExecution extends SQLContext#QueryExecution so binary compatibility should be preserved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The signature of the function to retrieve it has changed though. I think that we should rename this parameter and add a method that constructs a new instance of the inner subclass to return with the name
queryExecution. I think its worth rerunning the optimizer to not have to recompile all our perf tools.