[SQL][DOC] improved a comment #6332
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Member
|
It doesn't seem that different, so hard to object to, but what does this really clarify? |
Contributor
Author
|
I agree, it's no biggy, but the method signature says select(Column) and not selectExpr(...), so the original comment doesn't seem valid on the first sight. I'm still new to Spark so it's for you to decide, but I found it a bit confusing |
Contributor
Author
|
btw, I like your anomaly detection talk :) |
asfgit
pushed a commit
that referenced
this pull request
Jun 16, 2015
[SQL][DOC] I found it a bit confusing when I came across it for the first time in the docs Author: Radek Ostrowski <[email protected]> Author: radek <[email protected]> Closes #6332 from radek1st/master and squashes the following commits: dae3347 [Radek Ostrowski] fixed typo c76bb3a [radek] improved a comment (cherry picked from commit 4bd10fd) Signed-off-by: Sean Owen <[email protected]>
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
[SQL][DOC] I found it a bit confusing when I came across it for the first time in the docs Author: Radek Ostrowski <[email protected]> Author: radek <[email protected]> Closes apache#6332 from radek1st/master and squashes the following commits: dae3347 [Radek Ostrowski] fixed typo c76bb3a [radek] improved a comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SQL][DOC] I found it a bit confusing when I came across it for the first time in the docs