[Spark-7781][MLLIB] gradient boosted trees.train regressor missing max bins #6331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion the default of 32 in other places where it mentioned 100
Contributor
Author
|
Seems like a spurious git failure, @AmplabJenkins retest this please. |
|
Test build #33284 has finished for PR 6331 at commit
|
|
Test build #33285 has finished for PR 6331 at commit
|
Contributor
Author
|
cc @jkbradley |
Member
|
LGTM but first I'll retest this please since it's been a little while. |
|
Test build #35491 has finished for PR 6331 at commit
|
Member
|
silly Jenkins test this please |
|
Test build #35511 has finished for PR 6331 at commit
|
Member
|
Merging with master and branch-1.4 @holdenk Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Jun 23, 2015
…ax bins Author: Holden Karau <[email protected]> Closes #6331 from holdenk/SPARK-7781-GradientBoostedTrees.trainRegressor-missing-max-bins and squashes the following commits: 2894695 [Holden Karau] remove extra blank line 2573e8d [Holden Karau] Update the scala side of the pythonmllibapi and make the test a bit nicer too 3a09170 [Holden Karau] add maxBins to to the train method as well af7f274 [Holden Karau] Add maxBins to GradientBoostedTrees.trainRegressor and correctly mention the default of 32 in other places where it mentioned 100 (cherry picked from commit 164fe2a) Signed-off-by: Joseph K. Bradley <[email protected]>
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 25, 2015
…ax bins Author: Holden Karau <[email protected]> Closes apache#6331 from holdenk/SPARK-7781-GradientBoostedTrees.trainRegressor-missing-max-bins and squashes the following commits: 2894695 [Holden Karau] remove extra blank line 2573e8d [Holden Karau] Update the scala side of the pythonmllibapi and make the test a bit nicer too 3a09170 [Holden Karau] add maxBins to to the train method as well af7f274 [Holden Karau] Add maxBins to GradientBoostedTrees.trainRegressor and correctly mention the default of 32 in other places where it mentioned 100 (cherry picked from commit 164fe2a) Signed-off-by: Joseph K. Bradley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.