Skip to content

[SPARK-7762] [MLLIB] set default value for outputCol #6289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[SPARK-7762] [MLLIB] set default value for outputCol #6289

wants to merge 4 commits into from

Conversation

@mengxr
Copy link
Contributor

@mengxr mengxr commented May 20, 2015

Set a default value for outputCol instead of forcing users to name it. This is useful for intermediate transformers in the pipeline. @jkbradley

@AmplabJenkins
Copy link

AmplabJenkins commented May 20, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 20, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 20, 2015

Test build #33158 has started for PR 6289 at commit bff8667.

@SparkQA
Copy link

SparkQA commented May 20, 2015

Test build #33158 has finished for PR 6289 at commit bff8667.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 20, 2015

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 20, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33158/
Test FAILed.

@mengxr
Copy link
Contributor Author

mengxr commented May 20, 2015

test this please

@AmplabJenkins
Copy link

AmplabJenkins commented May 20, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 20, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 20, 2015

Test build #33163 has started for PR 6289 at commit bff8667.

@jkbradley
Copy link
Member

jkbradley commented May 20, 2015

LGTM
This will have a merge conflict with [https://github.com//pull/6139]

@SparkQA
Copy link

SparkQA commented May 20, 2015

Test build #33163 has finished for PR 6289 at commit bff8667.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 20, 2015

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 20, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33163/
Test FAILed.

@jkbradley
Copy link
Member

jkbradley commented May 20, 2015

Streaming failure

@SparkQA
Copy link

SparkQA commented May 20, 2015

Test build #839 has started for PR 6289 at commit bff8667.

@AmplabJenkins
Copy link

AmplabJenkins commented May 20, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 20, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 20, 2015

Test build #33183 has started for PR 6289 at commit 54edebc.

@SparkQA
Copy link

SparkQA commented May 21, 2015

Test build #839 has finished for PR 6289 at commit bff8667.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

jkbradley commented May 21, 2015

Merging into master and branch-1.4

asfgit pushed a commit that referenced this pull request May 21, 2015
@mengxr @jkbradley
[SPARK-7762] [MLLIB] set default value for outputCol
5f64269 
Set a default value for `outputCol` instead of forcing users to name it. This is useful for intermediate transformers in the pipeline. jkbradley

Author: Xiangrui Meng <[email protected]>

Closes #6289 from mengxr/SPARK-7762 and squashes the following commits:

54edebc [Xiangrui Meng] merge master
bff8667 [Xiangrui Meng] update unit test
171246b [Xiangrui Meng] add unit test for outputCol
a4321bd [Xiangrui Meng] set default value for outputCol

(cherry picked from commit c330e52)
Signed-off-by: Joseph K. Bradley <[email protected]>
@asfgit asfgit closed this in c330e52 May 21, 2015
@SparkQA
Copy link

SparkQA commented May 21, 2015

Test build #33183 has finished for PR 6289 at commit 54edebc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 21, 2015

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 21, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33183/
Test PASSed.

@jkbradley
Copy link
Member

jkbradley commented May 21, 2015

Oops, 2 sets of tests...glad they passed

jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@mengxr @jeanlyn
[SPARK-7762] [MLLIB] set default value for outputCol
5b796da 
Set a default value for `outputCol` instead of forcing users to name it. This is useful for intermediate transformers in the pipeline. jkbradley

Author: Xiangrui Meng <[email protected]>

Closes apache#6289 from mengxr/SPARK-7762 and squashes the following commits:

54edebc [Xiangrui Meng] merge master
bff8667 [Xiangrui Meng] update unit test
171246b [Xiangrui Meng] add unit test for outputCol
a4321bd [Xiangrui Meng] set default value for outputCol
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@mengxr @jeanlyn
[SPARK-7762] [MLLIB] set default value for outputCol
942574e 
Set a default value for `outputCol` instead of forcing users to name it. This is useful for intermediate transformers in the pipeline. jkbradley

Author: Xiangrui Meng <[email protected]>

Closes apache#6289 from mengxr/SPARK-7762 and squashes the following commits:

54edebc [Xiangrui Meng] merge master
bff8667 [Xiangrui Meng] update unit test
171246b [Xiangrui Meng] add unit test for outputCol
a4321bd [Xiangrui Meng] set default value for outputCol
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@mengxr @nemccarthy
[SPARK-7762] [MLLIB] set default value for outputCol
14fd867 
Set a default value for `outputCol` instead of forcing users to name it. This is useful for intermediate transformers in the pipeline. jkbradley

Author: Xiangrui Meng <[email protected]>

Closes apache#6289 from mengxr/SPARK-7762 and squashes the following commits:

54edebc [Xiangrui Meng] merge master
bff8667 [Xiangrui Meng] update unit test
171246b [Xiangrui Meng] add unit test for outputCol
a4321bd [Xiangrui Meng] set default value for outputCol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mengxr @AmplabJenkins @SparkQA @jkbradley