The default version of yarn is equal to the hadoop version #626
Conversation
|
Can one of the admins verify this patch? |
pom.xml
Outdated
There was a problem hiding this comment.
Could you also remove these changes around restructuring the dependency locations? These need to be tested and verified separately.
There was a problem hiding this comment.
Bascially what I want here is a ~10 to 15 line pull request we can verify and merge in quickly.
There was a problem hiding this comment.
This is not very good, otherwise the default value is 1.0.4
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-yarn-client</artifactId>
<version>1.0.4</version>
</dependency>There was a problem hiding this comment.
What's the problem exactly? We don't ever rely on the default version here, right? If someone tries to build with -Pyarn but they don't set the hadoop version to be higher - the build can fail.
There was a problem hiding this comment.
You're right. but in mvn -Pyarn clean package, the hadoop version is 2.2.0
There was a problem hiding this comment.
Leaving the dependency declarations as they are now, mvn -DskipTests clean package can not be executed
There was a problem hiding this comment.
When hadop.version is 1.0.4 , yarn.version is also 1.0.4
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-yarn-client</artifactId>
<version>${yarn.version}</version>
</dependency>
is not correct, so mvn -DskipTests clean package can not be executed
There was a problem hiding this comment.
Ah I see. I didn't understand what you were saying before. Is the issue just that the dependency resolution fails?
There was a problem hiding this comment.
Yes, I'm sorry, my english is relatively bad.
There was a problem hiding this comment.
@pwendell
I tested the current environment ,when leaving the yarn dependency declarations as they are now,mvn -DskipTests clean package can work.I will restore modified.
I suggest to change back after 1.0 release
|
Great - thanks for paring this down. I can merge it. Let's look at cleaning this up once we ship 1.0. |
3 participants
This is a part of PR 590