Skip to content

SPARK-1700: Close socket file descriptors on task completion #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

SPARK-1700: Close socket file descriptors on task completion #623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,16 @@ private[spark] class PythonRDD[T: ClassTag](
override def compute(split: Partition, context: TaskContext): Iterator[Array[Byte]] = {
val startTime = System.currentTimeMillis
val env = SparkEnv.get
val worker = env.createPythonWorker(pythonExec, envVars.toMap)
val worker: Socket = env.createPythonWorker(pythonExec, envVars.toMap)
Copy link
Contributor

@pwendell pwendell May 3, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason to declare the type here?

Copy link
Contributor Author

@aarondav aarondav May 3, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the first time I read this code, I thought worker was some more interesting object. Just put the type to make it clear it's just a Socket.


// Ensure worker socket is closed on task completion. Closing sockets is idempotent.
context.addOnCompleteCallback(() =>
try {
worker.close()
} catch {
case e: Exception => logWarning("Failed to close worker socket", e)
}
)

@volatile var readerException: Exception = null

Expand Down