Skip to content

[SPARK-7686] [SQL] DescribeCommand is assigned wrong output attributes in SparkStrategies #6217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-7686] [SQL] DescribeCommand is assigned wrong output attributes in SparkStrategies #6217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4eec9f
Add failing regression test for SPARK-7686
JoshRosen May 17, 2015
953a344
Fix SPARK-7686 with a simple change in SparkStrategies.
JoshRosen May 17, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,10 +354,10 @@ private[sql] abstract class SparkStrategies extends QueryPlanner[SparkPlan] {
case c: CreateTableUsingAsSelect if !c.temporary =>
sys.error("Tables created with SQLContext must be TEMPORARY. Use a HiveContext instead.")

case LogicalDescribeCommand(table, isExtended) =>
case describe @ LogicalDescribeCommand(table, isExtended) =>
val resultPlan = self.sqlContext.executePlan(table).executedPlan
ExecutedCommand(
RunnableDescribeCommand(resultPlan, resultPlan.output, isExtended)) :: Nil
RunnableDescribeCommand(resultPlan, describe.output, isExtended)) :: Nil

case _ => Nil
}
Expand Down
6 changes: 6 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/sources/DDLTestSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,4 +99,10 @@ class DDLTestSuite extends DataSourceTest {
Row("arrayType", "array<string>", ""),
Row("structType", "struct<f1:string,f2:int>", "")
))

test("SPARK-7686 DescribeCommand should have correct physical plan output attributes") {
val attributes = sql("describe ddlPeople").queryExecution.executedPlan.output
assert(attributes.map(_.name) === Seq("col_name", "data_type", "comment"))
assert(attributes.map(_.dataType).toSet === Set(StringType))
}
}