[SPARK-7608] Clean up old state in RDDOperationGraphListener #6125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
You forget to insert jobId to jobIds. Could you write a simple test to verify we won't leak anything.
Contributor
|
You have to add unit tests that check for cleanup. For all components that keep track of information. |
|
Test build #32638 has finished for PR 6125 at commit
|
Member
|
LGTM |
Member
|
retest this please |
1 similar comment
Contributor
Author
|
retest this please |
|
Test build #32633 timed out for PR 6125 at commit |
|
Test build #32643 has finished for PR 6125 at commit
|
Contributor
Author
|
Master 1.4 |
asfgit
pushed a commit
that referenced
this pull request
May 13, 2015
This is necessary for streaming and long-running Spark applications. zsxwing tdas Author: Andrew Or <[email protected]> Closes #6125 from andrewor14/viz-listener-leak and squashes the following commits: 8660949 [Andrew Or] Fix thing + add tests 33c0843 [Andrew Or] Clean up old job state (cherry picked from commit f6e1838) Signed-off-by: Andrew Or <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
May 14, 2015
zsxwing Author: Andrew Or <[email protected]> Closes #6138 from andrewor14/dag-viz-clean-properly and squashes the following commits: 19d4e98 [Andrew Or] Add synchronize 02542d6 [Andrew Or] Rename overloaded variable d11bee1 [Andrew Or] Don't wait until all stages have started before rendering
asfgit
pushed a commit
that referenced
this pull request
May 14, 2015
zsxwing Author: Andrew Or <[email protected]> Closes #6138 from andrewor14/dag-viz-clean-properly and squashes the following commits: 19d4e98 [Andrew Or] Add synchronize 02542d6 [Andrew Or] Rename overloaded variable d11bee1 [Andrew Or] Don't wait until all stages have started before rendering
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
May 28, 2015
This is necessary for streaming and long-running Spark applications. zsxwing tdas Author: Andrew Or <[email protected]> Closes apache#6125 from andrewor14/viz-listener-leak and squashes the following commits: 8660949 [Andrew Or] Fix thing + add tests 33c0843 [Andrew Or] Clean up old job state
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
May 28, 2015
zsxwing Author: Andrew Or <[email protected]> Closes apache#6138 from andrewor14/dag-viz-clean-properly and squashes the following commits: 19d4e98 [Andrew Or] Add synchronize 02542d6 [Andrew Or] Rename overloaded variable d11bee1 [Andrew Or] Don't wait until all stages have started before rendering
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
Jun 12, 2015
This is necessary for streaming and long-running Spark applications. zsxwing tdas Author: Andrew Or <[email protected]> Closes apache#6125 from andrewor14/viz-listener-leak and squashes the following commits: 8660949 [Andrew Or] Fix thing + add tests 33c0843 [Andrew Or] Clean up old job state
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
Jun 12, 2015
zsxwing Author: Andrew Or <[email protected]> Closes apache#6138 from andrewor14/dag-viz-clean-properly and squashes the following commits: 19d4e98 [Andrew Or] Add synchronize 02542d6 [Andrew Or] Rename overloaded variable d11bee1 [Andrew Or] Don't wait until all stages have started before rendering
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
This is necessary for streaming and long-running Spark applications. zsxwing tdas Author: Andrew Or <[email protected]> Closes apache#6125 from andrewor14/viz-listener-leak and squashes the following commits: 8660949 [Andrew Or] Fix thing + add tests 33c0843 [Andrew Or] Clean up old job state
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
zsxwing Author: Andrew Or <[email protected]> Closes apache#6138 from andrewor14/dag-viz-clean-properly and squashes the following commits: 19d4e98 [Andrew Or] Add synchronize 02542d6 [Andrew Or] Rename overloaded variable d11bee1 [Andrew Or] Don't wait until all stages have started before rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for streaming and long-running Spark applications. @zsxwing @tdas