Skip to content

[MINOR] [CORE] Accept alternative mesos unsatisfied link error in test. #6119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[MINOR] [CORE] Accept alternative mesos unsatisfied link error in test. #6119

wants to merge 3 commits into from

Conversation

@tellison
Copy link
Member

@tellison tellison commented May 13, 2015

The IBM JVM reports an failed library load with a slightly different error message to Oracle's JVM. Update the test case to allow for either form.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 13, 2015

Test build #32613 has started for PR 6119 at commit b1079d7.

@SparkQA
Copy link

SparkQA commented May 13, 2015

Test build #32613 has finished for PR 6119 at commit b1079d7.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32613/
Test FAILed.

srowen
srowen reviewed May 13, 2015
View reviewed changes
core/src/test/scala/org/apache/spark/SparkContextSchedulerCreationSuite.scala Outdated
Copy link
Member

@srowen srowen May 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, if it's definitely an UnsatisfiedLinkError, I imagine it's sufficient to look for just "mesos"? that would differentiate it from not finding other libs without having to depend on the text like this. Would that work?

Copy link
Member Author

@tellison tellison May 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would work for me. I'll update.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 13, 2015

Test build #32616 has started for PR 6119 at commit f48c194.

@tellison
Copy link
Member Author

tellison commented May 13, 2015

... and learning to use ./dev/run-tests rather than mvn directly, the hard-way. Apologies for the noise with the Scala style check failure.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 13, 2015

Test build #32617 has started for PR 6119 at commit 2c5cd4e.

@SparkQA
Copy link

SparkQA commented May 13, 2015

Test build #32616 has finished for PR 6119 at commit f48c194.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32616/
Test PASSed.

@SparkQA
Copy link

SparkQA commented May 13, 2015

Test build #32617 has finished for PR 6119 at commit 2c5cd4e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32617/
Test PASSed.

@asfgit asfgit closed this in 51030b8 May 13, 2015
@srowen
Copy link
Member

srowen commented May 14, 2015

PS this can be considered the PR for https://issues.apache.org/jira/browse/SPARK-7635

mtbrandy pushed a commit to ibmsoe/spark that referenced this pull request May 18, 2015
@tellison @mtbrandy
[MINOR] [CORE] Accept alternative mesos unsatisfied link error in test.
80ce147 
The IBM JVM reports an failed library load with a slightly different error message to Oracle's JVM.  Update the test case to allow for either form.

Author: Tim Ellison <[email protected]>
Author: Tim Ellison <[email protected]>

Closes apache#6119 from tellison/LibraryLoading and squashes the following commits:

2c5cd4e [Tim Ellison] Reduce assertion to check for the mesos library name
f48c194 [Tim Ellison] Split long line
b1079d7 [Tim Ellison] [MINOR] [CORE] Accept alternative mesos unsatisfied link error in test.
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@tellison @jeanlyn
[MINOR] [CORE] Accept alternative mesos unsatisfied link error in test.
8030dc7 
The IBM JVM reports an failed library load with a slightly different error message to Oracle's JVM.  Update the test case to allow for either form.

Author: Tim Ellison <[email protected]>
Author: Tim Ellison <[email protected]>

Closes apache#6119 from tellison/LibraryLoading and squashes the following commits:

2c5cd4e [Tim Ellison] Reduce assertion to check for the mesos library name
f48c194 [Tim Ellison] Split long line
b1079d7 [Tim Ellison] [MINOR] [CORE] Accept alternative mesos unsatisfied link error in test.
mtbrandy pushed a commit to ibmsoe/spark that referenced this pull request Jun 11, 2015
@tellison @mtbrandy
[MINOR] [CORE] Accept alternative mesos unsatisfied link error in test.
7d98e85 
The IBM JVM reports an failed library load with a slightly different error message to Oracle's JVM.  Update the test case to allow for either form.

Author: Tim Ellison <[email protected]>
Author: Tim Ellison <[email protected]>

Closes apache#6119 from tellison/LibraryLoading and squashes the following commits:

2c5cd4e [Tim Ellison] Reduce assertion to check for the mesos library name
f48c194 [Tim Ellison] Split long line
b1079d7 [Tim Ellison] [MINOR] [CORE] Accept alternative mesos unsatisfied link error in test.
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@tellison @jeanlyn
[MINOR] [CORE] Accept alternative mesos unsatisfied link error in test.
8532943 
The IBM JVM reports an failed library load with a slightly different error message to Oracle's JVM.  Update the test case to allow for either form.

Author: Tim Ellison <[email protected]>
Author: Tim Ellison <[email protected]>

Closes apache#6119 from tellison/LibraryLoading and squashes the following commits:

2c5cd4e [Tim Ellison] Reduce assertion to check for the mesos library name
f48c194 [Tim Ellison] Split long line
b1079d7 [Tim Ellison] [MINOR] [CORE] Accept alternative mesos unsatisfied link error in test.
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@tellison @nemccarthy
[MINOR] [CORE] Accept alternative mesos unsatisfied link error in test.
c4685c0 
The IBM JVM reports an failed library load with a slightly different error message to Oracle's JVM.  Update the test case to allow for either form.

Author: Tim Ellison <[email protected]>
Author: Tim Ellison <[email protected]>

Closes apache#6119 from tellison/LibraryLoading and squashes the following commits:

2c5cd4e [Tim Ellison] Reduce assertion to check for the mesos library name
f48c194 [Tim Ellison] Split long line
b1079d7 [Tim Ellison] [MINOR] [CORE] Accept alternative mesos unsatisfied link error in test.
mtbrandy pushed a commit to ibmsoe/spark that referenced this pull request Jul 16, 2015
@tellison @mtbrandy
[MINOR] [CORE] Accept alternative mesos unsatisfied link error in test.
11494e3 
The IBM JVM reports an failed library load with a slightly different error message to Oracle's JVM.  Update the test case to allow for either form.

Author: Tim Ellison <[email protected]>
Author: Tim Ellison <[email protected]>

Closes apache#6119 from tellison/LibraryLoading and squashes the following commits:

2c5cd4e [Tim Ellison] Reduce assertion to check for the mesos library name
f48c194 [Tim Ellison] Split long line
b1079d7 [Tim Ellison] [MINOR] [CORE] Accept alternative mesos unsatisfied link error in test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tellison @AmplabJenkins @SparkQA @srowen