Skip to content

[SQL] Move some classes into packages that are more appropriate. #6108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[SQL] Move some classes into packages that are more appropriate. #6108

wants to merge 4 commits into from

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented May 13, 2015

JavaTypeInference into catalyst
types.DateUtils into catalyst
CacheManager into execution
DefaultParserDialect into catalyst

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build started.

@marmbrus
Copy link
Contributor

marmbrus commented May 13, 2015

LGTM

@SparkQA
Copy link

SparkQA commented May 13, 2015

Test build #32583 has started for PR 6108 at commit 2990f67.

@SparkQA
Copy link

SparkQA commented May 13, 2015

Test build #32583 has finished for PR 6108 at commit 2990f67.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32583/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 13, 2015

Test build #32587 has started for PR 6108 at commit 6e9e87c.

@SparkQA
Copy link

SparkQA commented May 13, 2015

Test build #32587 has finished for PR 6108 at commit 6e9e87c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32587/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 13, 2015

Test build #32601 has started for PR 6108 at commit 4e75c6a.

@SparkQA
Copy link

SparkQA commented May 13, 2015

Test build #32601 has finished for PR 6108 at commit 4e75c6a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32601/
Test PASSed.

marmbrus
marmbrus reviewed May 13, 2015
View reviewed changes
sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetIOSuite.scala Outdated
Copy link
Contributor

@marmbrus marmbrus May 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all in the wrong spot.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 13, 2015

Test build #32642 has started for PR 6108 at commit 3fc9613.

@SparkQA
Copy link

SparkQA commented May 13, 2015

Test build #32642 has finished for PR 6108 at commit 3fc9613.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32642/
Test PASSed.

asfgit pushed a commit that referenced this pull request May 13, 2015
@rxin @marmbrus
[SQL] Move some classes into packages that are more appropriate.
acd872b 
JavaTypeInference into catalyst
types.DateUtils into catalyst
CacheManager into execution
DefaultParserDialect into catalyst

Author: Reynold Xin <[email protected]>

Closes #6108 from rxin/sql-rename and squashes the following commits:

3fc9613 [Reynold Xin] Fixed import ordering.
83d9ff4 [Reynold Xin] Fixed codegen tests.
e271e86 [Reynold Xin] mima
f4e24a6 [Reynold Xin] [SQL] Move some classes into packages that are more appropriate.

(cherry picked from commit e683182)
Signed-off-by: Michael Armbrust <[email protected]>
@marmbrus
Copy link
Contributor

marmbrus commented May 13, 2015

Merged to master and 1.4

@asfgit asfgit closed this in e683182 May 13, 2015
@rxin rxin deleted the sql-rename branch May 13, 2015 23:43
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@rxin @jeanlyn
[SQL] Move some classes into packages that are more appropriate.
626b830 
JavaTypeInference into catalyst
types.DateUtils into catalyst
CacheManager into execution
DefaultParserDialect into catalyst

Author: Reynold Xin <[email protected]>

Closes apache#6108 from rxin/sql-rename and squashes the following commits:

3fc9613 [Reynold Xin] Fixed import ordering.
83d9ff4 [Reynold Xin] Fixed codegen tests.
e271e86 [Reynold Xin] mima
f4e24a6 [Reynold Xin] [SQL] Move some classes into packages that are more appropriate.
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@rxin @jeanlyn
[SQL] Move some classes into packages that are more appropriate.
d09832e 
JavaTypeInference into catalyst
types.DateUtils into catalyst
CacheManager into execution
DefaultParserDialect into catalyst

Author: Reynold Xin <[email protected]>

Closes apache#6108 from rxin/sql-rename and squashes the following commits:

3fc9613 [Reynold Xin] Fixed import ordering.
83d9ff4 [Reynold Xin] Fixed codegen tests.
e271e86 [Reynold Xin] mima
f4e24a6 [Reynold Xin] [SQL] Move some classes into packages that are more appropriate.
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@rxin @nemccarthy
[SQL] Move some classes into packages that are more appropriate.
da5c88f 
JavaTypeInference into catalyst
types.DateUtils into catalyst
CacheManager into execution
DefaultParserDialect into catalyst

Author: Reynold Xin <[email protected]>

Closes apache#6108 from rxin/sql-rename and squashes the following commits:

3fc9613 [Reynold Xin] Fixed import ordering.
83d9ff4 [Reynold Xin] Fixed codegen tests.
e271e86 [Reynold Xin] mima
f4e24a6 [Reynold Xin] [SQL] Move some classes into packages that are more appropriate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rxin @AmplabJenkins @marmbrus @SparkQA