Skip to content

[SPARK-7464] DAG visualization: highlight the same RDDs on hover #6100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-7464] DAG visualization: highlight the same RDDs on hover #6100

wants to merge 2 commits into from

Conversation

@andrewor14
Copy link
Contributor

@andrewor14 andrewor14 commented May 12, 2015

This is pretty useful for MLlib.

Andrew Or added 2 commits May 12, 2015 12:09
Assign classes to clusters and nodes, not IDs
90c6a7e 
The problem here is that we actually draw many of these graphs
on the same page (job page). Some of these graphs may share the
same node IDs (RDDs), and so we end up with multiple DOM elements
with the same ID, which is bad JS practice.
Link tooltips for nodes that belong to the same RDD
fefe2af
@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 12, 2015

Test build #32543 has started for PR 6100 at commit fefe2af.

@SparkQA
Copy link

SparkQA commented May 12, 2015

Test build #32543 has finished for PR 6100 at commit fefe2af.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • s"FileOutputCommitter or its subclass is expected, but got a $
    • trait FSBasedRelationProvider
    • abstract class OutputWriter

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32543/
Test FAILed.

@andrewor14
Copy link
Contributor Author

andrewor14 commented May 13, 2015

retest this please

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 13, 2015

Test build #32568 has started for PR 6100 at commit fefe2af.

@SparkQA
Copy link

SparkQA commented May 13, 2015

Test build #32568 has finished for PR 6100 at commit fefe2af.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32568/
Test FAILed.

@andrewor14
Copy link
Contributor Author

andrewor14 commented May 13, 2015

retest this please

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 13, 2015

Test build #32637 has started for PR 6100 at commit fefe2af.

@SparkQA
Copy link

SparkQA commented May 13, 2015

Test build #32637 has finished for PR 6100 at commit fefe2af.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32637/
Test PASSed.

@andrewor14
Copy link
Contributor Author

andrewor14 commented May 13, 2015

Master 1.4

asfgit pushed a commit that referenced this pull request May 13, 2015
[SPARK-7464] DAG visualization: highlight the same RDDs on hover
4b4f10b 
This is pretty useful for MLlib.

<img src="https://cloud.githubusercontent.com/assets/2133137/7599650/c7d03dd8-f8b8-11e4-8c0a-0a89e786c90f.png" width="400px"/>

Author: Andrew Or <[email protected]>

Closes #6100 from andrewor14/dag-viz-hover and squashes the following commits:

fefe2af [Andrew Or] Link tooltips for nodes that belong to the same RDD
90c6a7e [Andrew Or] Assign classes to clusters and nodes, not IDs

(cherry picked from commit 4440341)
Signed-off-by: Andrew Or <[email protected]>
@asfgit asfgit closed this in 4440341 May 13, 2015
@andrewor14 andrewor14 deleted the dag-viz-hover branch May 14, 2015 07:59
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@jeanlyn
[SPARK-7464] DAG visualization: highlight the same RDDs on hover
f893792 
This is pretty useful for MLlib.

<img src="https://cloud.githubusercontent.com/assets/2133137/7599650/c7d03dd8-f8b8-11e4-8c0a-0a89e786c90f.png" width="400px"/>

Author: Andrew Or <[email protected]>

Closes apache#6100 from andrewor14/dag-viz-hover and squashes the following commits:

fefe2af [Andrew Or] Link tooltips for nodes that belong to the same RDD
90c6a7e [Andrew Or] Assign classes to clusters and nodes, not IDs
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@jeanlyn
[SPARK-7464] DAG visualization: highlight the same RDDs on hover
fdcac57 
This is pretty useful for MLlib.

<img src="https://cloud.githubusercontent.com/assets/2133137/7599650/c7d03dd8-f8b8-11e4-8c0a-0a89e786c90f.png" width="400px"/>

Author: Andrew Or <[email protected]>

Closes apache#6100 from andrewor14/dag-viz-hover and squashes the following commits:

fefe2af [Andrew Or] Link tooltips for nodes that belong to the same RDD
90c6a7e [Andrew Or] Assign classes to clusters and nodes, not IDs
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@nemccarthy
[SPARK-7464] DAG visualization: highlight the same RDDs on hover
f35260e 
This is pretty useful for MLlib.

<img src="https://cloud.githubusercontent.com/assets/2133137/7599650/c7d03dd8-f8b8-11e4-8c0a-0a89e786c90f.png" width="400px"/>

Author: Andrew Or <[email protected]>

Closes apache#6100 from andrewor14/dag-viz-hover and squashes the following commits:

fefe2af [Andrew Or] Link tooltips for nodes that belong to the same RDD
90c6a7e [Andrew Or] Assign classes to clusters and nodes, not IDs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewor14 @AmplabJenkins @SparkQA