Skip to content

[SPARK-7572][MLLIB] do not import Param/Params under pyspark.ml #6094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-7572][MLLIB] do not import Param/Params under pyspark.ml #6094

wants to merge 1 commit into from

Conversation

@mengxr
Copy link
Contributor

@mengxr mengxr commented May 12, 2015

Remove Param and Params from pyspark.ml and add a section in the doc. @brkyvz

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 12, 2015

Test build #32529 has started for PR 6094 at commit 022abd6.

@brkyvz
Copy link
Contributor

brkyvz commented May 12, 2015

LGTM

@SparkQA
Copy link

SparkQA commented May 12, 2015

Test build #32529 has finished for PR 6094 at commit 022abd6.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • decisionTreeCode = '''class DecisionTreeParams(Params):
    • class DecisionTreeParams(Params):
    • class LinearRegression(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPredictionCol, HasMaxIter,
    • class LinearRegressionModel(JavaModel):
    • class TreeRegressorParams(object):
    • class RandomForestParams(object):
    • class GBTParams(object):
    • class DecisionTreeRegressor(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPredictionCol,
    • class DecisionTreeRegressionModel(JavaModel):
    • class RandomForestRegressor(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPredictionCol, HasSeed,
    • class RandomForestRegressionModel(JavaModel):
    • class GBTRegressor(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPredictionCol, HasMaxIter,
    • class GBTRegressionModel(JavaModel):
    • s"FileOutputCommitter or its subclass is expected, but got a $
    • trait FSBasedRelationProvider
    • abstract class OutputWriter

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32529/
Test FAILed.

@mengxr
Copy link
Contributor Author

mengxr commented May 12, 2015

test this please

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 12, 2015

Test build #32539 has started for PR 6094 at commit 022abd6.

@SparkQA
Copy link

SparkQA commented May 13, 2015

Test build #32539 has finished for PR 6094 at commit 022abd6.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • decisionTreeCode = '''class DecisionTreeParams(Params):
    • class DecisionTreeParams(Params):
    • class LinearRegression(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPredictionCol, HasMaxIter,
    • class LinearRegressionModel(JavaModel):
    • class TreeRegressorParams(object):
    • class RandomForestParams(object):
    • class GBTParams(object):
    • class DecisionTreeRegressor(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPredictionCol,
    • class DecisionTreeRegressionModel(JavaModel):
    • class RandomForestRegressor(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPredictionCol, HasSeed,
    • class RandomForestRegressionModel(JavaModel):
    • class GBTRegressor(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPredictionCol, HasMaxIter,
    • class GBTRegressionModel(JavaModel):
    • s"FileOutputCommitter or its subclass is expected, but got a $
    • trait FSBasedRelationProvider
    • abstract class OutputWriter

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32539/
Test FAILed.

@mengxr
Copy link
Contributor Author

mengxr commented May 13, 2015

The failed test was known to be flaky (SPARK-7497).

@mengxr
Copy link
Contributor Author

mengxr commented May 13, 2015

Merged into master and branch-1.4.

@asfgit asfgit closed this in 77f64c7 May 13, 2015
asfgit pushed a commit that referenced this pull request May 13, 2015
@mengxr
[SPARK-7572] [MLLIB] do not import Param/Params under pyspark.ml
08ec1af 
Remove `Param` and `Params` from `pyspark.ml` and add a section in the doc. brkyvz

Author: Xiangrui Meng <[email protected]>

Closes #6094 from mengxr/SPARK-7572 and squashes the following commits:

022abd6 [Xiangrui Meng] do not import Param/Params under spark.ml

(cherry picked from commit 77f64c7)
Signed-off-by: Xiangrui Meng <[email protected]>
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@mengxr @jeanlyn
[SPARK-7572] [MLLIB] do not import Param/Params under pyspark.ml
a57a1d0 
Remove `Param` and `Params` from `pyspark.ml` and add a section in the doc. brkyvz

Author: Xiangrui Meng <[email protected]>

Closes apache#6094 from mengxr/SPARK-7572 and squashes the following commits:

022abd6 [Xiangrui Meng] do not import Param/Params under spark.ml
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@mengxr @jeanlyn
[SPARK-7572] [MLLIB] do not import Param/Params under pyspark.ml
ba24358 
Remove `Param` and `Params` from `pyspark.ml` and add a section in the doc. brkyvz

Author: Xiangrui Meng <[email protected]>

Closes apache#6094 from mengxr/SPARK-7572 and squashes the following commits:

022abd6 [Xiangrui Meng] do not import Param/Params under spark.ml
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@mengxr @nemccarthy
[SPARK-7572] [MLLIB] do not import Param/Params under pyspark.ml
eeede54 
Remove `Param` and `Params` from `pyspark.ml` and add a section in the doc. brkyvz

Author: Xiangrui Meng <[email protected]>

Closes apache#6094 from mengxr/SPARK-7572 and squashes the following commits:

022abd6 [Xiangrui Meng] do not import Param/Params under spark.ml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mengxr @AmplabJenkins @SparkQA @brkyvz