[SPARK-7551][DataFrame] support backticks for DataFrame attribute resolution #6074

cloud-fan · 2015-05-12T06:53:35Z

No description provided.

cloud-fan · 2015-05-12T06:56:51Z

It should be better if we could reuse parser and analyzer to do this job or reopen #5505 after we can handle joins correctly.

AmplabJenkins · 2015-05-12T06:57:10Z

Merged build triggered.

AmplabJenkins · 2015-05-12T06:57:19Z

Merged build started.

SparkQA · 2015-05-12T06:59:21Z

Test build #32471 has started for PR 6074 at commit 54c4209.

rxin · 2015-05-12T07:01:18Z

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala

add some documentation to explain what this is for (and the above function).

in particular talk about backticks.

also i'd document in english what the accepted attribute is.

AmplabJenkins · 2015-05-12T07:32:10Z

Merged build triggered.

AmplabJenkins · 2015-05-12T07:32:19Z

Merged build started.

SparkQA · 2015-05-12T07:34:02Z

Test build #32472 has started for PR 6074 at commit 399fc8d.

rxin · 2015-05-12T07:44:41Z

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala

while loop? (just want to avoid closures for a very hot loop here...)

AmplabJenkins · 2015-05-12T07:52:10Z

Merged build triggered.

AmplabJenkins · 2015-05-12T07:52:19Z

Merged build started.

SparkQA · 2015-05-12T07:52:29Z

Test build #32474 has started for PR 6074 at commit 209263d.

AmplabJenkins · 2015-05-12T07:57:12Z

Merged build triggered.

AmplabJenkins · 2015-05-12T07:57:17Z

Merged build started.

SparkQA · 2015-05-12T07:58:01Z

Test build #32477 has started for PR 6074 at commit e218d99.

SparkQA · 2015-05-12T08:48:05Z

Test build #32471 has finished for PR 6074 at commit 54c4209.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-05-12T08:48:09Z

Merged build finished. Test PASSed.

AmplabJenkins · 2015-05-12T08:48:10Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32471/
Test PASSed.

SparkQA · 2015-05-12T09:25:22Z

Test build #32472 has finished for PR 6074 at commit 399fc8d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-05-12T09:25:26Z

Merged build finished. Test PASSed.

AmplabJenkins · 2015-05-12T09:25:27Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32472/
Test PASSed.

SparkQA · 2015-05-12T09:49:43Z

Test build #32474 has finished for PR 6074 at commit 209263d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2015-05-13T05:32:40Z

Test build #32586 has started for PR 6074 at commit 2b86699.

rxin · 2015-05-13T05:35:46Z

sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala

actually i think we want to allow spaces?

basically just move the test case into allowed, and revert your very last commit.

AmplabJenkins · 2015-05-13T06:07:10Z

Merged build triggered.

AmplabJenkins · 2015-05-13T06:07:19Z

Merged build started.

SparkQA · 2015-05-13T06:09:07Z

Test build #32589 has started for PR 6074 at commit e6f579e.

rxin · 2015-05-13T06:24:22Z

LGTM.

SparkQA · 2015-05-13T06:58:52Z

Test build #32585 has finished for PR 6074 at commit 903b319.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-05-13T06:58:57Z

Merged build finished. Test FAILed.

AmplabJenkins · 2015-05-13T06:58:57Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32585/
Test FAILed.

SparkQA · 2015-05-13T07:24:45Z

Test build #32586 has finished for PR 6074 at commit 2b86699.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-05-13T07:24:49Z

Merged build finished. Test PASSed.

AmplabJenkins · 2015-05-13T07:24:50Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32586/
Test PASSed.

SparkQA · 2015-05-13T07:27:40Z

Test build #32589 has finished for PR 6074 at commit e6f579e.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-05-13T07:27:47Z

Merged build finished. Test FAILed.

AmplabJenkins · 2015-05-13T07:27:47Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32589/
Test FAILed.

rxin · 2015-05-13T07:39:49Z

Jenkins, retest this please.

AmplabJenkins · 2015-05-13T07:42:11Z

Merged build triggered.

AmplabJenkins · 2015-05-13T07:42:16Z

Merged build started.

SparkQA · 2015-05-13T07:44:17Z

Test build #32597 has started for PR 6074 at commit e6f579e.

SparkQA · 2015-05-13T09:40:08Z

Test build #32597 has finished for PR 6074 at commit e6f579e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-05-13T09:40:12Z

Merged build finished. Test PASSed.

AmplabJenkins · 2015-05-13T09:40:12Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32597/
Test PASSed.

rxin · 2015-05-13T19:47:30Z

Thanks. Merging this in.

…olution Author: Wenchen Fan <[email protected]> Closes #6074 from cloud-fan/7551 and squashes the following commits: e6f579e [Wenchen Fan] allow space 2b86699 [Wenchen Fan] handle blank e218d99 [Wenchen Fan] address comments 54c4209 [Wenchen Fan] fix 7551 (cherry picked from commit 213a6f3) Signed-off-by: Reynold Xin <[email protected]>

…olution Author: Wenchen Fan <[email protected]> Closes apache#6074 from cloud-fan/7551 and squashes the following commits: e6f579e [Wenchen Fan] allow space 2b86699 [Wenchen Fan] handle blank e218d99 [Wenchen Fan] address comments 54c4209 [Wenchen Fan] fix 7551

fix 7551

54c4209

rxin reviewed May 12, 2015
View reviewed changes

cloud-fan force-pushed the 7551 branch from aed795c to 399fc8d Compare May 12, 2015 07:30

rxin reviewed May 12, 2015
View reviewed changes

cloud-fan force-pushed the 7551 branch from 399fc8d to 209263d Compare May 12, 2015 07:49

address comments

e218d99

cloud-fan force-pushed the 7551 branch from 209263d to e218d99 Compare May 12, 2015 07:56

rxin reviewed May 13, 2015
View reviewed changes

allow space

e6f579e

asfgit closed this in 213a6f3 May 13, 2015

[SPARK-7551][DataFrame] support backticks for DataFrame attribute resolution #6074

[SPARK-7551][DataFrame] support backticks for DataFrame attribute resolution #6074

Uh oh!

Conversation

cloud-fan commented May 12, 2015

Uh oh!

cloud-fan commented May 12, 2015

Uh oh!

AmplabJenkins commented May 12, 2015

Uh oh!

AmplabJenkins commented May 12, 2015

Uh oh!

SparkQA commented May 12, 2015

Uh oh!

rxin May 12, 2015

Choose a reason for hiding this comment

Uh oh!

rxin May 12, 2015

Choose a reason for hiding this comment

Uh oh!

AmplabJenkins commented May 12, 2015

Uh oh!

AmplabJenkins commented May 12, 2015

Uh oh!

SparkQA commented May 12, 2015

Uh oh!

rxin May 12, 2015

Choose a reason for hiding this comment

Uh oh!

AmplabJenkins commented May 12, 2015

Uh oh!

AmplabJenkins commented May 12, 2015

Uh oh!

SparkQA commented May 12, 2015

Uh oh!

AmplabJenkins commented May 12, 2015

Uh oh!

AmplabJenkins commented May 12, 2015

Uh oh!

SparkQA commented May 12, 2015

Uh oh!

SparkQA commented May 12, 2015

Uh oh!

AmplabJenkins commented May 12, 2015

Uh oh!

AmplabJenkins commented May 12, 2015

Uh oh!

SparkQA commented May 12, 2015

Uh oh!

AmplabJenkins commented May 12, 2015

Uh oh!

AmplabJenkins commented May 12, 2015

Uh oh!

SparkQA commented May 12, 2015

Uh oh!

SparkQA commented May 13, 2015

Uh oh!

rxin May 13, 2015

Choose a reason for hiding this comment

Uh oh!

rxin May 13, 2015

Choose a reason for hiding this comment

Uh oh!

AmplabJenkins commented May 13, 2015

Uh oh!

AmplabJenkins commented May 13, 2015

Uh oh!

SparkQA commented May 13, 2015

Uh oh!

rxin commented May 13, 2015

Uh oh!

SparkQA commented May 13, 2015

Uh oh!

AmplabJenkins commented May 13, 2015

Uh oh!

AmplabJenkins commented May 13, 2015

Uh oh!

SparkQA commented May 13, 2015

Uh oh!

AmplabJenkins commented May 13, 2015