Skip to content

[SPARK-7534][Core][WebUI] Fix the Stage table when a stage is missing #6061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-7534][Core][WebUI] Fix the Stage table when a stage is missing #6061

wants to merge 2 commits into from

Conversation

@zsxwing
Copy link
Member

@zsxwing zsxwing commented May 11, 2015

Just improved the Stage table when a stage is missing.

Before:

screen shot 2015-05-11 at 10 11 51 am

After:

screen shot 2015-05-11 at 10 26 09 am

@AmplabJenkins
Copy link

AmplabJenkins commented May 11, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 11, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 11, 2015

Test build #32410 has started for PR 6061 at commit 6299197.

@andrewor14
Copy link
Contributor

andrewor14 commented May 11, 2015

LGTM, merging into master 1.4 once tests pass

@SparkQA
Copy link

SparkQA commented May 11, 2015

Test build #32410 has finished for PR 6061 at commit 6299197.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class RankingMetrics(JavaModelWrapper):

@AmplabJenkins
Copy link

AmplabJenkins commented May 11, 2015

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 11, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32410/
Test PASSed.

kayousterhout
kayousterhout reviewed May 12, 2015
View reviewed changes
core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala Outdated
Copy link
Contributor

@kayousterhout kayousterhout May 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nit, but does this need to change? It seems like changing it to "-" is inconsistent with the way we handle other missing information (e.g., when there's no shuffle read data, we leave it blank, instead of having "-")

Copy link
Member Author

@zsxwing zsxwing May 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 12, 2015

Test build #32458 has started for PR 6061 at commit 09fe862.

@SparkQA
Copy link

SparkQA commented May 12, 2015

Test build #32458 has finished for PR 6061 at commit 09fe862.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32458/
Test PASSed.

@andrewor14
Copy link
Contributor

andrewor14 commented May 12, 2015

Ok, merging into master 1.4 for real.

asfgit pushed a commit that referenced this pull request May 12, 2015
@zsxwing
[SPARK-7534] [CORE] [WEBUI] Fix the Stage table when a stage is missing
af374ed 
Just improved the Stage table when a stage is missing.

Before:

![screen shot 2015-05-11 at 10 11 51 am](https://cloud.githubusercontent.com/assets/1000778/7570842/2ba37380-f7c8-11e4-9b5f-cf1a6264b2a4.png)

After:

![screen shot 2015-05-11 at 10 26 09 am](https://cloud.githubusercontent.com/assets/1000778/7570848/33703152-f7c8-11e4-81a8-d53dd72d7b8d.png)

Author: zsxwing <[email protected]>

Closes #6061 from zsxwing/SPARK-7534 and squashes the following commits:

09fe862 [zsxwing] Leave it blank rather than '-'
6299197 [zsxwing] Fix the Stage table when a stage is missing
@asfgit asfgit closed this in 8a4edec May 12, 2015
@zsxwing zsxwing deleted the SPARK-7534 branch May 12, 2015 15:30
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@zsxwing @jeanlyn
[SPARK-7534] [CORE] [WEBUI] Fix the Stage table when a stage is missing
5d9bc4f 
Just improved the Stage table when a stage is missing.

Before:

![screen shot 2015-05-11 at 10 11 51 am](https://cloud.githubusercontent.com/assets/1000778/7570842/2ba37380-f7c8-11e4-9b5f-cf1a6264b2a4.png)

After:

![screen shot 2015-05-11 at 10 26 09 am](https://cloud.githubusercontent.com/assets/1000778/7570848/33703152-f7c8-11e4-81a8-d53dd72d7b8d.png)

Author: zsxwing <[email protected]>

Closes apache#6061 from zsxwing/SPARK-7534 and squashes the following commits:

09fe862 [zsxwing] Leave it blank rather than '-'
6299197 [zsxwing] Fix the Stage table when a stage is missing
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@zsxwing @jeanlyn
[SPARK-7534] [CORE] [WEBUI] Fix the Stage table when a stage is missing
77de634 
Just improved the Stage table when a stage is missing.

Before:

![screen shot 2015-05-11 at 10 11 51 am](https://cloud.githubusercontent.com/assets/1000778/7570842/2ba37380-f7c8-11e4-9b5f-cf1a6264b2a4.png)

After:

![screen shot 2015-05-11 at 10 26 09 am](https://cloud.githubusercontent.com/assets/1000778/7570848/33703152-f7c8-11e4-81a8-d53dd72d7b8d.png)

Author: zsxwing <[email protected]>

Closes apache#6061 from zsxwing/SPARK-7534 and squashes the following commits:

09fe862 [zsxwing] Leave it blank rather than '-'
6299197 [zsxwing] Fix the Stage table when a stage is missing
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@zsxwing @nemccarthy
[SPARK-7534] [CORE] [WEBUI] Fix the Stage table when a stage is missing
a16892f 
Just improved the Stage table when a stage is missing.

Before:

![screen shot 2015-05-11 at 10 11 51 am](https://cloud.githubusercontent.com/assets/1000778/7570842/2ba37380-f7c8-11e4-9b5f-cf1a6264b2a4.png)

After:

![screen shot 2015-05-11 at 10 26 09 am](https://cloud.githubusercontent.com/assets/1000778/7570848/33703152-f7c8-11e4-81a8-d53dd72d7b8d.png)

Author: zsxwing <[email protected]>

Closes apache#6061 from zsxwing/SPARK-7534 and squashes the following commits:

09fe862 [zsxwing] Leave it blank rather than '-'
6299197 [zsxwing] Fix the Stage table when a stage is missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zsxwing @AmplabJenkins @SparkQA @andrewor14 @kayousterhout