Skip to content

[SPARK-7532][STREAMING] StreamingContext.start() made to logWarning and not throw exception #6060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

[SPARK-7532][STREAMING] StreamingContext.start() made to logWarning and not throw exception #6060

wants to merge 7 commits into from

Conversation

@tdas
Copy link
Contributor

@tdas tdas commented May 11, 2015

No description provided.

@AmplabJenkins
Copy link

AmplabJenkins commented May 11, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 11, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 11, 2015

Test build #32409 has started for PR 6060 at commit 1a9a818.

@tdas tdas mentioned this pull request May 11, 2015
Closed
@SparkQA
Copy link

SparkQA commented May 11, 2015

Test build #32409 has finished for PR 6060 at commit 1a9a818.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class PCA(val k: Int)
    • class HasCheckpointInterval(Params):
    • class Evaluator(Params):
    • class ALS(JavaEstimator, HasCheckpointInterval, HasMaxIter, HasPredictionCol, HasRegParam, HasSeed):
    • class ALSModel(JavaModel):
    • class MulticlassMetrics(JavaModelWrapper):
    • class RankingMetrics(JavaModelWrapper):
    • class ChiSqSelectorModel(JavaVectorTransformer):
    • class ChiSqSelector(object):
    • case class SimpleCatalystConf(caseSensitiveAnalysis: Boolean) extends CatalystConf
    • class SimpleCatalog(val conf: CatalystConf) extends Catalog

@AmplabJenkins
Copy link

AmplabJenkins commented May 11, 2015

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 11, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32409/
Test PASSed.

zsxwing
zsxwing reviewed May 11, 2015
View reviewed changes
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala Outdated
Copy link
Member

@zsxwing zsxwing May 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add "return" here.

Copy link
Contributor Author

@tdas tdas May 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, missed that while splitting this out from a different PR.

Copy link
Contributor Author

@tdas tdas May 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, I will fix this when #6058 goes in.

@tdas
Merge remote-tracking branch 'apache-github/master' into SPARK-7532
5bf031b 
Conflicts:
	streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala
	streaming/src/test/scala/org/apache/spark/streaming/StreamingContextSuite.scala
@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 12, 2015

Test build #32448 has started for PR 6060 at commit 5bf031b.

@tdas
Copy link
Contributor Author

tdas commented May 12, 2015

test this please.

@tdas
Copy link
Contributor Author

tdas commented May 12, 2015

@zsxwing Can you take a look at this.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 12, 2015

Test build #32449 has started for PR 6060 at commit 99c7678.

@SparkQA
Copy link

SparkQA commented May 12, 2015

Test build #32448 has finished for PR 6060 at commit 5bf031b.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32448/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 12, 2015

Test build #32449 has finished for PR 6060 at commit 99c7678.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32449/
Test FAILed.

@SparkQA
Copy link

SparkQA commented May 12, 2015

Test build #32450 has started for PR 6060 at commit 7dadfc3.

@zsxwing
Copy link
Member

zsxwing commented May 12, 2015

LGTM except a minor docs issue

zsxwing
zsxwing reviewed May 12, 2015
View reviewed changes
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala Outdated
Copy link
Member

@zsxwing zsxwing May 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need to mention SparkException here.

Copy link
Contributor Author

@tdas tdas May 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I need to modify it to say SparkException will be thrown only when the context has been already stopped.

@SparkQA
Copy link

SparkQA commented May 12, 2015

Test build #32450 has finished for PR 6060 at commit 7dadfc3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32450/
Test PASSed.

@tdas tdas mentioned this pull request May 12, 2015
Closed
@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 12, 2015

Test build #32468 has started for PR 6060 at commit 6fe2e83.

@SparkQA
Copy link

SparkQA commented May 12, 2015

Test build #32468 has finished for PR 6060 at commit 6fe2e83.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32468/
Test PASSed.

@tdas
Copy link
Contributor Author

tdas commented May 12, 2015

I am merging this.

asfgit pushed a commit that referenced this pull request May 12, 2015
@tdas
[SPARK-7532] [STREAMING] StreamingContext.start() made to logWarning …
2bbb685 
…and not throw exception

Author: Tathagata Das <[email protected]>

Closes #6060 from tdas/SPARK-7532 and squashes the following commits:

6fe2e83 [Tathagata Das] Update docs
7dadfc3 [Tathagata Das] Fixed bug again
99c7678 [Tathagata Das] Added logInfo
65aec20 [Tathagata Das] Fix bug
5bf031b [Tathagata Das] Merge remote-tracking branch 'apache-github/master' into SPARK-7532
1a9a818 [Tathagata Das] Fix scaladoc
c584313 [Tathagata Das] StreamingContext.start() made to logWarning and not throw exception

(cherry picked from commit ec6f2a9)
Signed-off-by: Tathagata Das <[email protected]>
@asfgit asfgit closed this in ec6f2a9 May 12, 2015
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@tdas @jeanlyn
[SPARK-7532] [STREAMING] StreamingContext.start() made to logWarning …
29ce709 
…and not throw exception

Author: Tathagata Das <[email protected]>

Closes apache#6060 from tdas/SPARK-7532 and squashes the following commits:

6fe2e83 [Tathagata Das] Update docs
7dadfc3 [Tathagata Das] Fixed bug again
99c7678 [Tathagata Das] Added logInfo
65aec20 [Tathagata Das] Fix bug
5bf031b [Tathagata Das] Merge remote-tracking branch 'apache-github/master' into SPARK-7532
1a9a818 [Tathagata Das] Fix scaladoc
c584313 [Tathagata Das] StreamingContext.start() made to logWarning and not throw exception
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@tdas @jeanlyn
[SPARK-7532] [STREAMING] StreamingContext.start() made to logWarning …
eb2c218 
…and not throw exception

Author: Tathagata Das <[email protected]>

Closes apache#6060 from tdas/SPARK-7532 and squashes the following commits:

6fe2e83 [Tathagata Das] Update docs
7dadfc3 [Tathagata Das] Fixed bug again
99c7678 [Tathagata Das] Added logInfo
65aec20 [Tathagata Das] Fix bug
5bf031b [Tathagata Das] Merge remote-tracking branch 'apache-github/master' into SPARK-7532
1a9a818 [Tathagata Das] Fix scaladoc
c584313 [Tathagata Das] StreamingContext.start() made to logWarning and not throw exception
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@tdas @nemccarthy
[SPARK-7532] [STREAMING] StreamingContext.start() made to logWarning …
ff4a075 
…and not throw exception

Author: Tathagata Das <[email protected]>

Closes apache#6060 from tdas/SPARK-7532 and squashes the following commits:

6fe2e83 [Tathagata Das] Update docs
7dadfc3 [Tathagata Das] Fixed bug again
99c7678 [Tathagata Das] Added logInfo
65aec20 [Tathagata Das] Fix bug
5bf031b [Tathagata Das] Merge remote-tracking branch 'apache-github/master' into SPARK-7532
1a9a818 [Tathagata Das] Fix scaladoc
c584313 [Tathagata Das] StreamingContext.start() made to logWarning and not throw exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tdas @AmplabJenkins @SparkQA @zsxwing