[MINOR] Avoid passing the PermGenSize option to IBM JVMs.

[tellison]

IBM's Java VM doesn't have the concept of a permgen, so this option shouldn't be passed when the vendor property shows it is an IBM JDK.

[AmplabJenkins]

Can one of the admins verify this patch?

[srowen]

Does it actually fail to start if it sees this option?

[srowen]

Minor: This doesn't have to have the elses and thus extra level or two of nesting.

[tellison]

ACK

[srowen]

Jenkins, add to whitelist

[AmplabJenkins]

Merged build triggered.

[AmplabJenkins]

Merged build started.

[SparkQA]

Test build #32398 has started for PR 6055 at commit 42a8c3f.

[tellison]

The IBM VM will still start if passed -XX options that have no impact, so this is just being a good citizen in case that position changes in the future.

There are other IBM JVM changes I have that are a bit more significant. Let me know if you want an umbrella JIRA to cover running on IBM Java.

[srowen]

My only concern is complicating the code for args that don't actually cause a problem; I imagine any JVM should often be prepared to ignore -XX args it doesn't know since they are such a free-for-all. Still, not much harm in this particular change. But is there a lot more you have in mind?

[tellison]

Not for -XX args. I have some changes to SizeEstimator, endianness, etc. for correctness, and thinking of extending java-opts to allow for vendor specific args. We can discuss on dev list and/or JIRA.

[SparkQA]

Test build #32398 has finished for PR 6055 at commit 42a8c3f.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Merged build finished. Test PASSed.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32398/
Test PASSed.

[AmplabJenkins]

Merged build triggered.

[AmplabJenkins]

Merged build started.

[SparkQA]

Test build #32497 has started for PR 6055 at commit d27174b.

[SparkQA]

Test build #32497 has finished for PR 6055 at commit d27174b.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Merged build finished. Test PASSed.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32497/
Test PASSed.

[srowen]

Looks OK to me, excepting the minor simplification of those else branches.

[AmplabJenkins]

Merged build triggered.

[AmplabJenkins]

Merged build started.

[SparkQA]

Test build #32611 has started for PR 6055 at commit 6ad4266.

[AmplabJenkins]

Merged build triggered.

[AmplabJenkins]

Merged build started.

[SparkQA]

Test build #32612 has started for PR 6055 at commit 3a0fb66.

[SparkQA]

Test build #32612 has finished for PR 6055 at commit 3a0fb66.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Merged build finished. Test FAILed.

[AmplabJenkins]

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32612/
Test FAILed.

[SparkQA]

Test build #32611 has finished for PR 6055 at commit 6ad4266.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Merged build finished. Test PASSed.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32611/
Test PASSed.