Skip to content

Conversation

@scwf
Copy link
Contributor

@scwf scwf commented May 9, 2015

/cc @yhuai and @davies

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented May 9, 2015

Test build #32301 has started for PR 6027 at commit ae30c22.

@SparkQA
Copy link

SparkQA commented May 9, 2015

Test build #32301 has finished for PR 6027 at commit ae30c22.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32301/
Test PASSed.

@marmbrus
Copy link
Contributor

marmbrus commented May 9, 2015

Sorry for the confusion, but this JIRA was not about adding methods for mutating data columns, but fixing places in the execution engine where you could get errors because the types are not handled correctly.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented May 10, 2015

Test build #32319 has started for PR 6027 at commit 274b39e.

@scwf
Copy link
Contributor Author

scwf commented May 10, 2015

@marmbrus, thanks your explain. But after i go through the DateType related code i think we have converted date type to int when execution.
I added a unit test for date type support.

@marmbrus
Copy link
Contributor

You are correct that most of the places have been converted but there are still some mistakes. For example, I believe date columns in partitioning columns. JDBC was also doing the conversion wrong when the ticket was opened, but I believe that has been fixed now.

@SparkQA
Copy link

SparkQA commented May 10, 2015

Test build #32319 has finished for PR 6027 at commit 274b39e.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32319/
Test FAILed.

@scwf
Copy link
Contributor Author

scwf commented May 11, 2015

For date columns in partitioning columns, should i start this work after #5526 is in, right?

@marmbrus
Copy link
Contributor

Check with @adrian-wang who might be working on the partitioning column issue already.

@adrian-wang
Copy link
Contributor

For the idea of getDate and setDate interface I think it is already rejected in #2284 . And I'm working on partitioning column already...

@scwf
Copy link
Contributor Author

scwf commented May 14, 2015

i am closing this

@scwf scwf closed this May 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants