-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-6784] [SQL] Clean up all the inbound/outbound conversions for DateType #6027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Merged build triggered. |
|
Merged build started. |
|
Test build #32301 has started for PR 6027 at commit |
|
Test build #32301 has finished for PR 6027 at commit
|
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
|
Sorry for the confusion, but this JIRA was not about adding methods for mutating data columns, but fixing places in the execution engine where you could get errors because the types are not handled correctly. |
|
Merged build triggered. |
|
Merged build started. |
|
Test build #32319 has started for PR 6027 at commit |
|
@marmbrus, thanks your explain. But after i go through the DateType related code i think we have converted date type to int when execution. |
|
You are correct that most of the places have been converted but there are still some mistakes. For example, I believe date columns in partitioning columns. JDBC was also doing the conversion wrong when the ticket was opened, but I believe that has been fixed now. |
|
Test build #32319 has finished for PR 6027 at commit
|
|
Merged build finished. Test FAILed. |
|
Test FAILed. |
|
For date columns in partitioning columns, should i start this work after #5526 is in, right? |
|
Check with @adrian-wang who might be working on the partitioning column issue already. |
|
For the idea of |
|
i am closing this |
/cc @yhuai and @davies