Skip to content

[SPARK-7329][MLLIB] simplify ParamGridBuilder impl #5873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-7329][MLLIB] simplify ParamGridBuilder impl #5873

wants to merge 2 commits into from

Conversation

@mengxr
Copy link
Contributor

@mengxr mengxr commented May 3, 2015

as suggested by @justinuang on #5601.

@SparkQA
Copy link

SparkQA commented May 3, 2015

Test build #31705 has finished for PR 5873 at commit d08f9cf.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class ParamGridBuilder(object):

@justinuang
Copy link

justinuang commented May 3, 2015

You can consider using set equality for the test, but other than that, it looks good! Thanks!

@mengxr
Copy link
Contributor Author

mengxr commented May 4, 2015

set cannot use dict as elements because dict is not hashable.

@mengxr
Copy link
Contributor Author

mengxr commented May 4, 2015

Merged into master.

@asfgit asfgit closed this in 1ffa8cb May 4, 2015
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@mengxr @jeanlyn
[SPARK-7329] [MLLIB] simplify ParamGridBuilder impl
2b0eaf7 
as suggested by justinuang on apache#5601.

Author: Xiangrui Meng <[email protected]>

Closes apache#5873 from mengxr/SPARK-7329 and squashes the following commits:

d08f9cf [Xiangrui Meng] simplify tests
b7a7b9b [Xiangrui Meng] simplify grid build
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@mengxr @jeanlyn
[SPARK-7329] [MLLIB] simplify ParamGridBuilder impl
45c51e9 
as suggested by justinuang on apache#5601.

Author: Xiangrui Meng <[email protected]>

Closes apache#5873 from mengxr/SPARK-7329 and squashes the following commits:

d08f9cf [Xiangrui Meng] simplify tests
b7a7b9b [Xiangrui Meng] simplify grid build
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@mengxr @nemccarthy
[SPARK-7329] [MLLIB] simplify ParamGridBuilder impl
a6654b3 
as suggested by justinuang on apache#5601.

Author: Xiangrui Meng <[email protected]>

Closes apache#5873 from mengxr/SPARK-7329 and squashes the following commits:

d08f9cf [Xiangrui Meng] simplify tests
b7a7b9b [Xiangrui Meng] simplify grid build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mengxr @SparkQA @justinuang