[SPARK-7194][MLLIB] Vectors factors method for sparse vectors should accept the output of zipWithIndex #5766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Contributor
|
@kaka1992 I don't see why this is useful. Creating a dense vector directly is certainly more efficient. |
Contributor
Author
|
@mengxr Just provide a way to turn DeseV to SparseV easily. Somebody may need this. |
Contributor
|
See #5756. Users should be able to write |
Contributor
Author
|
@mengxr Ok, I'll close this pr. |
Member
|
@kaka1992 this wasn't quite the proposal in the JIRA anyway; it had to do with accepting either order of tuple. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new Vectors.sparse(arr: Array[Double])