SPARK-6993 : Add default min, max methods for JavaDoubleRDD

[ogirardot]

The default method will use Guava's Ordering instead of
java.util.Comparator.naturalOrder() because it's not available
in Java 7, only in Java 8.

[srowen]

I don't think you need this and the project doesn't depend directly on commons-collections anyway IIRC.

[ogirardot]

I removed the bad import - it was a typo

[ogirardot]

I've taken your reviews into account.

[srowen]

ok to test

[SparkQA]

Test build #30517 has finished for PR 5571 at commit 7c5f4ab.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • case class Params(
  • sealed abstract class Node extends Serializable
  • sealed trait Split extends Serializable
  • final class CategoricalSplit(
  • final class ContinuousSplit(override val featureIndex: Int, val threshold: Double) extends Split
  • trait DecisionTreeModel
• This patch does not change any dependencies.

[ogirardot]

Seems like the precision for float is needed in the test.
I'll add it back

[srowen]

No, just assert that == is true. Looks like the framework actually rejects use of this method? It didn't say it didn't equal, weirdly

[ogirardot]

I pushed the modifications,
The third time is always the winning one ! :)

[SparkQA]

Test build #30519 has finished for PR 5571 at commit 99c3416.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.
• This patch does not change any dependencies.

[SparkQA]

Test build #30521 has finished for PR 5571 at commit 7fe2e9e.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.
• This patch does not change any dependencies.

[srowen]

LGTM. Though I imagine this is not controversial, I would love to get a nod from @JoshRosen or @pwendell or @rxin as it offers a new API method.

[ogirardot]

of course, have a nice weekend :)

[rxin]

LGTM. Merging in master.