Skip to content

Conversation

@davies
Copy link
Contributor

@davies davies commented Apr 16, 2015

select(['cola', 'colb'])

groupby(['colA', 'colB'])
groupby([df.colA, df.colB])

df.sort('A', ascending=True)
df.sort(['A', 'B'], ascending=True)
df.sort(['A', 'B'], ascending=[1, 0])

cc @rxin

@SparkQA
Copy link

SparkQA commented Apr 17, 2015

Test build #30440 has finished for PR 5544 at commit bcbbcab.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@SparkQA
Copy link

SparkQA commented Apr 17, 2015

Test build #30443 has finished for PR 5544 at commit adb2816.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add some docstring here to explain what this does?

@rxin
Copy link
Contributor

rxin commented Apr 17, 2015

Looks good to me, except some comments on documentation. Thanks for doing this!

@SparkQA
Copy link

SparkQA commented Apr 17, 2015

Test build #30456 has finished for PR 5544 at commit 4944058.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@rxin
Copy link
Contributor

rxin commented Apr 17, 2015

Thanks. I'm going to merge this and fix some minor doc issues.

@asfgit asfgit closed this in c84d916 Apr 17, 2015
asfgit pushed a commit that referenced this pull request Apr 17, 2015
As a follow up PR to #5544.

cc davies

Author: Reynold Xin <[email protected]>

Closes #5558 from rxin/sort-doc-improvement and squashes the following commits:

f4c276f [Reynold Xin] Review feedback.
d2dcf24 [Reynold Xin] Minor fix to SPARK-6958: Improve Python docstring for DataFrame.sort.
HyukjinKwon added a commit that referenced this pull request Jan 9, 2020
… compatible" aliases

### What changes were proposed in this pull request?

This PR adds a note that we're not adding "pandas compatible" aliases anymore.

### Why are the changes needed?

We added "pandas compatible" aliases as of #5544 and #6066 . There are too many differences and I don't think it makes sense to add such aliases anymore at this moment.

I was even considering deprecating them out but decided to take a more conservative approache by just documenting it.

### Does this PR introduce any user-facing change?

No.

### How was this patch tested?

Existing tests should cover.

Closes #27142 from HyukjinKwon/SPARK-30464.

Authored-by: HyukjinKwon <[email protected]>
Signed-off-by: HyukjinKwon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants