-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-6957] [SPARK-6958] [SQL] improve API compatibility to pandas #5544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Conflicts: python/pyspark/sql/dataframe.py
|
Test build #30440 has finished for PR 5544 at commit
|
|
Test build #30443 has finished for PR 5544 at commit
|
python/pyspark/sql/dataframe.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add some docstring here to explain what this does?
|
Looks good to me, except some comments on documentation. Thanks for doing this! |
|
Test build #30456 has finished for PR 5544 at commit
|
|
Thanks. I'm going to merge this and fix some minor doc issues. |
As a follow up PR to #5544. cc davies Author: Reynold Xin <[email protected]> Closes #5558 from rxin/sort-doc-improvement and squashes the following commits: f4c276f [Reynold Xin] Review feedback. d2dcf24 [Reynold Xin] Minor fix to SPARK-6958: Improve Python docstring for DataFrame.sort.
… compatible" aliases ### What changes were proposed in this pull request? This PR adds a note that we're not adding "pandas compatible" aliases anymore. ### Why are the changes needed? We added "pandas compatible" aliases as of #5544 and #6066 . There are too many differences and I don't think it makes sense to add such aliases anymore at this moment. I was even considering deprecating them out but decided to take a more conservative approache by just documenting it. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Existing tests should cover. Closes #27142 from HyukjinKwon/SPARK-30464. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
cc @rxin