Skip to content

[SPARK-5634] [core] Show correct message in HS when no incomplete apps f... #5515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-5634] [core] Show correct message in HS when no incomplete apps f... #5515

wants to merge 1 commit into from

Conversation

@vanzin
Copy link
Contributor

@vanzin vanzin commented Apr 14, 2015

...ound.

@SparkQA
Copy link

SparkQA commented Apr 15, 2015

Test build #30283 has finished for PR 5515 at commit f74ecf1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@andrewor14
Copy link
Contributor

andrewor14 commented Apr 15, 2015

LGTM merging into master 1.3 and 1.2 thanks.

asfgit pushed a commit that referenced this pull request Apr 15, 2015
[SPARK-5634] [core] Show correct message in HS when no incomplete app…
0e5ca9e 
…s f...

...ound.

Author: Marcelo Vanzin <[email protected]>

Closes #5515 from vanzin/SPARK-5634 and squashes the following commits:

f74ecf1 [Marcelo Vanzin] [SPARK-5634] [core] Show correct message in HS when no incomplete apps found.

(cherry picked from commit 30a6e0d)
Signed-off-by: Andrew Or <[email protected]>
asfgit pushed a commit that referenced this pull request Apr 15, 2015
[SPARK-5634] [core] Show correct message in HS when no incomplete app…
5845a62 
…s f...

...ound.

Author: Marcelo Vanzin <[email protected]>

Closes #5515 from vanzin/SPARK-5634 and squashes the following commits:

f74ecf1 [Marcelo Vanzin] [SPARK-5634] [core] Show correct message in HS when no incomplete apps found.

(cherry picked from commit 30a6e0d)
Signed-off-by: Andrew Or <[email protected]>
@asfgit asfgit closed this in 30a6e0d Apr 15, 2015
@JoshRosen
Copy link
Contributor

JoshRosen commented Apr 15, 2015

I'm going to revert this patch in branch-1.2 (1.2.3) because it broke compilation there (the requestedIncomplete isn't defined in that branch). If we want this fix for 1.2, we can open a new PR, but this seems like such a low-impact problem that it's probably not worth fixing there.

@andrewor14
Copy link
Contributor

andrewor14 commented Apr 15, 2015

Oops, my mistake. Thanks Josh.

@vanzin vanzin deleted the SPARK-5634 branch April 16, 2015 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vanzin @SparkQA @andrewor14 @JoshRosen