-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-5957][ML] better handling of parameters #5431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add a few methods to Params
|
Test build #29906 has finished for PR 5431 at commit
|
|
Test build #29910 has finished for PR 5431 at commit
|
|
Test build #29909 has finished for PR 5431 at commit
|
|
Test build #30150 has finished for PR 5431 at commit
|
|
Should this method in Params be made abstract? I just realized we haven't been using it, and making it abstract would force users to think about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add test for "params.clear"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Make sure that the input param is initialized before this gets called." will be unclear to new developers. Maybe move this to parameter-specific doc:
@param param: Make sure that this param is initialized before this method gets called.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
@mengxr I added minor comment but don't have major ones. That's it for now! |
|
LGTM once tests pass |
|
Test build #30210 has finished for PR 5431 at commit
|
|
Test build #30212 has finished for PR 5431 at commit
|
|
Merged into master. |
Same as #5431 but for Python. jkbradley Author: Xiangrui Meng <[email protected]> Closes #5534 from mengxr/SPARK-6893 and squashes the following commits: d3b519b [Xiangrui Meng] address comments ebaccc6 [Xiangrui Meng] style update fce244e [Xiangrui Meng] update explainParams with test 4d6b07a [Xiangrui Meng] add tests 5294500 [Xiangrui Meng] update default param handling in python
The design doc was posted on the JIRA page. Python changes will be in a follow-up PR. @jkbradley
ml.param.shared.Paramsinstead of inParam.ParamsandParamMap.SchemaUtilsfromParams.