-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-1537] [YARN] [WiP] Add history provider for YARN Application Timeline Server #5423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-1537] [YARN] [WiP] Add history provider for YARN Application Timeline Server #5423
Conversation
|
Test build #29863 has finished for PR 5423 at commit
|
|
Test build #30029 has finished for PR 5423 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why need this, since it only call the same parent method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well-caught, probably an override that I ended up not expanding
|
This is WiP build, with a lot more tests, with integration ones going all the way from a wired up spark context to an in-memory ATS server; this needs to be wrapped up with the GET calls to retrieve the data and verify full round trip of all event structures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use logDebug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
|
Test build #30378 timed out for PR 5423 at commit |
|
Test build #30607 has finished for PR 5423 at commit
|
|
Test build #30605 has finished for PR 5423 at commit
|
|
Test build #30669 has finished for PR 5423 at commit
|
|
Note that this adds a new profile |
|
Test build #30695 has finished for PR 5423 at commit
|
|
This iteration has a simpler service flush/shutdown logic, with specific messages for each action queued, and no attempt to trigger the yarn service stop when a stopApplication event is received. |
|
Test build #30770 has finished for PR 5423 at commit
|
|
Test build #30780 has finished for PR 5423 at commit
|
|
Test build #30781 timed out for PR 5423 at commit |
|
There's no obvious reason why the Jenkins build failed; the console says all the tests passed. |
|
Yes, it says it timed out (two comments up) |
|
Jenkins, retest this please. |
|
Test build #30862 has finished for PR 5423 at commit
|
|
Test build #31164 has finished for PR 5423 at commit
|
|
Test build #31575 has finished for PR 5423 at commit
|
|
I'll mark the |
|
Test build #31593 has finished for PR 5423 at commit
|
|
Test build #32022 has finished for PR 5423 at commit
|
|
Test build #32223 has finished for PR 5423 at commit
|
|
Test build #32232 has started for PR 5423 at commit |
|
Test build #47267 has finished for PR 5423 at commit
|
|
Test build #47270 has finished for PR 5423 at commit
|
|
Test build #47346 has finished for PR 5423 at commit
|
|
Test build #47495 has started for PR 5423 at commit |
|
Test build #47550 has finished for PR 5423 at commit
|
|
Test build #47596 has finished for PR 5423 at commit
|
…ter (the one with the service API merged in)
…ew SPARK-11315 publisher branch
…request pushed. This is for more reliable polling for changes during integration with YARN-7889
…d track attempt versions. This is for more reliable polling for changes during integration with YARN-7889
…f improvement in test running in the process. Tests can register "failureActions" for execution on a test failure; closures to dump the state of things & so have better diagnostics
…s this. In production even 10s is probably too short, so it doesn't make things much worse
…ATS URL (as info level wasn't giving any details on whether/when entities were published, or under what); downgrade event drop to info & not warning
e134e29 to
2a5a739
Compare
|
I'm going to close this pull request. If this is still relevant and you are interested in pushing it forward, please open a new pull request. Thanks! |
|
yes, it is still relevant, yes it was awaiting review, no I wasn't expecting it to be closed |
|
@steveloughran I was under the impression this was not meant to be merged, as it would require YARN 2.6 (2.7?) and that's not yet assume-able in Spark. At this point Spark 2.x is on 2.2+, but here's an argument maybe for bumping that up. But I do agree that long-lived PRs probably aren't ideal here |
|
I'm about to resubmit it. The way the code is structured, the 2.6 specific stuff lives under yarn/src/history, as discussed in earlier points in this PR. Everything happily builds and tests on Hadoop <2.6, this feature and its tests only only get built on 2.6+ |
|
now succeeded by #10545 |
This pull request incorporates the work of SPARK-11314 and SPARK-11315, adding in the history server side of the system: a subclass of
ApplicationHistoryProviderwhich can enumerate application histories listed in the YARN timeline server, and retrieve them on demand.It includes
FsHistoryProvider, the History Server needs to be started with a keytab).