Skip to content

[SPARK-6765] Fix test code style for SQL #5412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

[SPARK-6765] Fix test code style for SQL #5412

wants to merge 8 commits into from

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Apr 8, 2015

So we can turn style checker on for test code.

@SparkQA
Copy link

SparkQA commented Apr 8, 2015

Test build #29842 has started for PR 5412 at commit ef4ec48.

@SparkQA
Copy link

SparkQA commented Apr 8, 2015

Test build #29842 has finished for PR 5412 at commit ef4ec48.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@AmplabJenkins
Copy link

AmplabJenkins commented Apr 8, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29842/
Test FAILed.

liancheng
liancheng reviewed Apr 8, 2015
View reviewed changes
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
Copy link
Contributor

@liancheng liancheng Apr 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want public fields have explicit type too?

Copy link
Contributor Author

@rxin rxin Apr 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - but there is no rule for it yet.

liancheng
liancheng reviewed Apr 8, 2015
View reviewed changes
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/PlanTest.scala Outdated
Copy link
Contributor

@liancheng liancheng Apr 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is off here.

@SparkQA
Copy link

SparkQA commented Apr 8, 2015

Test build #29846 has started for PR 5412 at commit f2f4348.

@SparkQA
Copy link

SparkQA commented Apr 8, 2015

Test build #29846 has finished for PR 5412 at commit f2f4348.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@AmplabJenkins
Copy link

AmplabJenkins commented Apr 8, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29846/
Test FAILed.

liancheng
liancheng reviewed Apr 8, 2015
View reviewed changes
sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala
Copy link
Contributor

@liancheng liancheng Apr 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing return type of this one?

Copy link
Contributor Author

@rxin rxin Apr 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was too long - either wrap it, or just remove :Unit

Copy link
Contributor

@marmbrus marmbrus Apr 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this form of method is going to be deprecated.

@SparkQA
Copy link

SparkQA commented Apr 8, 2015

Test build #29887 has started for PR 5412 at commit 0b03fbb.

@SparkQA
Copy link

SparkQA commented Apr 8, 2015

Test build #29888 has started for PR 5412 at commit 82d0944.

@SparkQA
Copy link

SparkQA commented Apr 8, 2015

Test build #29887 has finished for PR 5412 at commit 0b03fbb.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@AmplabJenkins
Copy link

AmplabJenkins commented Apr 8, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29887/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Apr 8, 2015

Test build #29888 has finished for PR 5412 at commit 82d0944.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@AmplabJenkins
Copy link

AmplabJenkins commented Apr 8, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29888/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Apr 8, 2015

Test build #29890 has started for PR 5412 at commit 8c7250a.

@SparkQA
Copy link

SparkQA commented Apr 8, 2015

Test build #29890 has finished for PR 5412 at commit 8c7250a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@AmplabJenkins
Copy link

AmplabJenkins commented Apr 8, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29890/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Apr 9, 2015

Test build #29904 has started for PR 5412 at commit 9098a31.

@SparkQA
Copy link

SparkQA commented Apr 9, 2015

Test build #29904 has finished for PR 5412 at commit 9098a31.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@AmplabJenkins
Copy link

AmplabJenkins commented Apr 9, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29904/
Test PASSed.

@marmbrus
Copy link
Contributor

marmbrus commented Apr 9, 2015

For @rxin 's sanity I'll merge this now :)

We can update the final minor comments in followups.

@marmbrus
Copy link
Contributor

marmbrus commented Apr 9, 2015

Actually, apache git is down :(

@rxin
Copy link
Contributor Author

rxin commented Apr 9, 2015

Ok I've merged it.

@asfgit asfgit closed this in 1b2aab8 Apr 9, 2015
@rxin rxin mentioned this pull request Apr 13, 2015
Closed
asfgit pushed a commit that referenced this pull request Apr 13, 2015
@rxin
[SPARK-6765] Enable scalastyle on test code.
c5b0b29 
Turn scalastyle on for all test code. Most of the violations have been resolved in my previous pull requests:

Core: #5484
SQL: #5412
MLlib: #5411
GraphX: #5410
Streaming: #5409

Author: Reynold Xin <[email protected]>

Closes #5486 from rxin/test-style-enable and squashes the following commits:

01683de [Reynold Xin] Fixed new code.
a4ab46e [Reynold Xin] Fixed tests.
20adbc8 [Reynold Xin] Missed one violation.
5e36521 [Reynold Xin] [SPARK-6765] Enable scalastyle on test code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rxin @SparkQA @AmplabJenkins @marmbrus @liancheng