[MLlib] [SPARK-6713] Iterators in columnSimilarities for mapPartitionsWithIndex #5364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rezazadeh
changed the title
Member
|
Yeah that looks like a great change to avoid allocating so much memory at once. |
|
Test PASSed. |
Contributor
|
Merged into master. Thanks! |
karlhigley
added a commit
to karlhigley/lexrank-summarizer
that referenced
this pull request
Jun 1, 2015
This could happen during mapPartitionsWithIndex in a dense and large column - this way Spark can spill the pairs onto disk instead of building all the pairs before handing them to Spark. (See SPARK-6713, apache/spark#5364, from which this code is lifted.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Iterators in columnSimilarities to allow mapPartitionsWithIndex to spill to disk. This could happen in a dense and large column - this way Spark can spill the pairs onto disk instead of building all the pairs before handing them to Spark.
Another PR coming to update documentation.