[SPARK-6694][SQL]SparkSQL CLI must be able to specify an option --database on the command line.

[adachij2002]

SparkSQL CLI has an option --database as follows.
But, the option --database is ignored.

$ spark-sql --help
:
CLI options:
    :
    --database <databasename>     Specify the database to use

[rxin]

cc @liancheng

Jenkins, test this please.

[liancheng]

@adachij2002 Would you mind to add a test case for this in CliSuite? We can pass --database <db> via extraArgs in runCliWithin there.

[adachij2002]

@liancheng Thanks for your comment.
I've added a testcase.

[WangTaoTheTonic]

Noticed that the permission is changed from 644 to 755:

sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala 100644 → 100755

Could you tell me why?

[adachij2002]

@WangTaoTheTonic Sorry, I edited that file on Windows.
I restored the file permission from 755 to 644.

[marmbrus]

ok to test

[marmbrus]

Why did this need to be moved out?

[adachij2002]

I need this test transactional.

1. create database for test db by SparkSQL CLI.
2. test --database option by SparkSQL command line.
   But the runCliWithin method will delete schema information.
   I modified to delete schema information in before/after of the test method.

[SparkQA]

Test build #30099 has finished for PR 5345 at commit 846f83e.

• This patch fails Scala style tests.
• This patch merges cleanly.
• This patch adds no public classes.
• This patch does not change any dependencies.

[liancheng]

Please either use

def runCliWithin(
    timeout: FiniteDuration,
    extraArgs: Seq[String] = Seq.empty)(
    queriesAndExpectedAnswers: (String, String)*): Unit = {
  ...
}

or

def runCliWithin
    (timeout: FiniteDuration, extraArgs: Seq[String] = Seq.empty)
    (queriesAndExpectedAnswers: (String, String)*): Unit = {
  ...
}

[adachij2002]

@liancheng I fixed it according to your suggestion.

[liancheng]

retest this please.

[liancheng]

The last Scala style check failure should be irrelevant.

Left a few minor styling comments. Otherwise this LGTM pending Jenkins. Thanks for working on this!

[SparkQA]

Test build #30167 has finished for PR 5345 at commit 846f83e.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.
• This patch does not change any dependencies.

[SparkQA]

Test build #30392 has finished for PR 5345 at commit df81086.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.
• This patch does not change any dependencies.

[SparkQA]

Test build #30405 has finished for PR 5345 at commit 8659084.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.
• This patch does not change any dependencies.

[liancheng]

Thanks for working on this! Merging to master.