Skip to content

Conversation

@davies
Copy link
Contributor

@davies davies commented Apr 1, 2015

In order to do inbound checking and type conversion, we should use Literal.create() instead of constructor.

@SparkQA
Copy link

SparkQA commented Apr 2, 2015

Test build #29577 has started for PR 5320 at commit 5f8c0fd.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this line is now over 100 chars

@rxin
Copy link
Contributor

rxin commented Apr 2, 2015

LGTM as soon as you fix the style issues and jenkins pass.

@SparkQA
Copy link

SparkQA commented Apr 2, 2015

Test build #29577 has finished for PR 5320 at commit 5f8c0fd.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Data(
    • case class Data(
    • s" but class priors vector pi had $
    • s" but class conditionals array theta had $
    • case class Data(word: String, vector: Array[Float])
    • class MessageWithHeader extends AbstractReferenceCounted implements FileRegion
    • class LinearClassificationModel(LinearModel):
    • class LogisticRegressionModel(LinearClassificationModel):
    • class SVMModel(LinearClassificationModel):
    • class UDFRegistration(object):
    • class Analyzer(
    • trait CheckAnalysis
    • case class CreateStruct(children: Seq[NamedExpression]) extends Expression
    • case class Literal protected (value: Any, dataType: DataType) extends LeafExpression
  • This patch does not change any dependencies.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29577/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Apr 2, 2015

Test build #29578 has started for PR 5320 at commit 1667604.

@davies davies changed the title use Literal.create instread of constructor [SPARK-6663] [SQL] use Literal.create instread of constructor Apr 2, 2015
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29578/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Apr 2, 2015

Test build #633 has started for PR 5320 at commit 1667604.

@SparkQA
Copy link

SparkQA commented Apr 2, 2015

Test build #633 has finished for PR 5320 at commit 1667604.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@rxin
Copy link
Contributor

rxin commented Apr 2, 2015

Thanks. Merging in master.

@asfgit asfgit closed this in 40df5d4 Apr 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants