Skip to content

[SPARK-6578] Small rewrite to make the logic more clear in MessageWithHeader.transferTo. #5319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-6578] Small rewrite to make the logic more clear in MessageWithHeader.transferTo. #5319

wants to merge 1 commit into from

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Apr 1, 2015

No description provided.

@rxin
Copy link
Contributor Author

rxin commented Apr 1, 2015

cc @vanzin from #5234

@SparkQA
Copy link

SparkQA commented Apr 1, 2015

Test build #29574 has started for PR 5319 at commit 7c62a64.

@vanzin
Copy link
Contributor

vanzin commented Apr 1, 2015

LGTM pending tests.

@rxin rxin changed the title [SPARK-6578] Small rewrite to make the logic more clear in transferTo. [SPARK-6578] Small rewrite to make the logic more clear in MessageWithHeader.transferTo. Apr 1, 2015
@SparkQA
Copy link

SparkQA commented Apr 2, 2015

Test build #29574 has finished for PR 5319 at commit 7c62a64.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class MessageWithHeader extends AbstractReferenceCounted implements FileRegion
  • This patch does not change any dependencies.

@AmplabJenkins
Copy link

AmplabJenkins commented Apr 2, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29574/
Test PASSed.

@aarondav
Copy link
Contributor

aarondav commented Apr 2, 2015

LGTM too

@rxin
Copy link
Contributor Author

rxin commented Apr 2, 2015

Merging in 1.3 and master.

asfgit pushed a commit that referenced this pull request Apr 2, 2015
@rxin
[SPARK-6578] Small rewrite to make the logic more clear in MessageWit…
d697b76 
…hHeader.transferTo.

Author: Reynold Xin <[email protected]>

Closes #5319 from rxin/SPARK-6578 and squashes the following commits:

7c62a64 [Reynold Xin] Small rewrite to make the logic more clear in transferTo.

(cherry picked from commit 899ebcb)
Signed-off-by: Reynold Xin <[email protected]>
@asfgit asfgit closed this in 899ebcb Apr 2, 2015
@rxin rxin deleted the SPARK-6578 branch April 2, 2015 01:38
@rxin
Copy link
Contributor Author

rxin commented Apr 2, 2015

@vanzin do you mind making a PR for 1.2 branch for this fix?

@vanzin
Copy link
Contributor

vanzin commented Apr 2, 2015

I'll prepare a PR for 1.2 after I'm done with some stuff around here.

vanzin pushed a commit to vanzin/spark that referenced this pull request Apr 2, 2015
@rxin
[SPARK-6578] Small rewrite to make the logic more clear in MessageWit…
4d3395e 
…hHeader.transferTo.

Author: Reynold Xin <[email protected]>

Closes apache#5319 from rxin/SPARK-6578 and squashes the following commits:

7c62a64 [Reynold Xin] Small rewrite to make the logic more clear in transferTo.

(cherry picked from commit 899ebcb)
vanzin pushed a commit to vanzin/spark that referenced this pull request Apr 20, 2015
@rxin
[SPARK-6578] Small rewrite to make the logic more clear in MessageWit…
aba155d 
…hHeader.transferTo.

Author: Reynold Xin <[email protected]>

Closes apache#5319 from rxin/SPARK-6578 and squashes the following commits:

7c62a64 [Reynold Xin] Small rewrite to make the logic more clear in transferTo.

(cherry picked from commit 899ebcb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rxin @SparkQA @vanzin @AmplabJenkins @aarondav