Fix Scala Style #531
Closed
Fix Scala Style #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Contributor
There was a problem hiding this comment.
for this one u can put all of them on a single line, i.e.
if (i < 4) 0 == prng42.nextInt(3) else 0 == prng43.nextInt(3)
Contributor
|
lgtm otherwise. Thanks! |
Contributor
Author
|
@rxin done 👍 😉 |
Contributor
|
Thanks. I merged this. |
asfgit
pushed a commit
that referenced
this pull request
Apr 24, 2014
Any comments are welcome Author: Sandeep <[email protected]> Closes #531 from techaddict/stylefix-1 and squashes the following commits: 7492730 [Sandeep] Pass 4 98b2428 [Sandeep] fix rxin suggestions b5e2e6f [Sandeep] Pass 3 05932d7 [Sandeep] fix if else styling 2 08690e5 [Sandeep] fix if else styling (cherry picked from commit a03ac22) Signed-off-by: Reynold Xin <[email protected]>
pdeyhim
pushed a commit
to pdeyhim/spark-1
that referenced
this pull request
Jun 25, 2014
Any comments are welcome Author: Sandeep <[email protected]> Closes apache#531 from techaddict/stylefix-1 and squashes the following commits: 7492730 [Sandeep] Pass 4 98b2428 [Sandeep] fix rxin suggestions b5e2e6f [Sandeep] Pass 3 05932d7 [Sandeep] fix if else styling 2 08690e5 [Sandeep] fix if else styling
helenyugithub
pushed a commit
to helenyugithub/spark
that referenced
this pull request
Aug 20, 2019
…mpty serialized data (apache#531) - Fixes https://issues.apache.org/jira/browse/SPARK-27267 - Upstream PR: https://github.com/apache/spark/pull/24242/files
helenyugithub
pushed a commit
to helenyugithub/spark
that referenced
this pull request
Aug 20, 2019
* [SPARK-27267][CORE] Update snappy to avoid error when decompressing empty serialized data (apache#531) * [SPARK-27514][SQL] Skip collapsing windows with empty window expressions (apache#538) * Bump hadoop to 2.9.2-palantir.5 (apache#537)
turboFei
added a commit
to turboFei/spark
that referenced
this pull request
Nov 6, 2025
<img width="1328" alt="image" src="https://media.github.corp.ebay.com/user/27990/files/975c93e5-3fe8-4712-9a8a-bcb6fef318b8"> --------- Co-authored-by: Wu, Jieping <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any comments are welcome