-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-54269][PYTHON] Upgrade cloudpickle to 3.1.2 for Python 3.14
#52964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Could you review this, @HyukjinKwon and @zhengruifeng ? |
cloudpickle to 3.1.2cloudpickle to 3.1.2 for Python 3.14
zhengruifeng
approved these changes
Nov 10, 2025
Member
Author
|
Thank you, @zhengruifeng . |
LuciferYang
approved these changes
Nov 10, 2025
Member
Author
|
Thank you, @LuciferYang |
dongjoon-hyun
added a commit
that referenced
this pull request
Nov 10, 2025
### What changes were proposed in this pull request? This PR aims to upgrade `cloudpickle` to 3.1.2. ### Why are the changes needed? To support Python 3.14 properly. - https://github.com/cloudpipe/cloudpickle/releases/tag/v3.1.2 - https://github.com/cloudpipe/cloudpickle/blob/master/CHANGES.md#312 > Fix pickling of abstract base classes containing type annotations for Python 3.14. (cloudpipe/cloudpickle#578) ### Does this PR introduce _any_ user-facing change? No, Python 3.14 support is not announced yet. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52964 from dongjoon-hyun/SPARK-54269. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 9754e17) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
Author
|
Merged to master/4.1 for Apache Spark 4.1.0. |
dongjoon-hyun
added a commit
that referenced
this pull request
Nov 10, 2025
…ython 3.14 ### What changes were proposed in this pull request? This PR aims to enable `test_in_memory_data_source` in Python 3.14. ### Why are the changes needed? After upgrading to the latest `cloudpickle` 3.1.2, I verified that the test passed on Python 3.14.0. - #52964 ``` $ python/run-tests --parallelism 1 --testnames pyspark.sql.tests.test_python_datasource --python-executables python3 Running PySpark tests. Output is in /Users/dongjoon/APACHE/spark-merge/python/unit-tests.log Will test against the following Python executables: ['python3'] Will test the following Python tests: ['pyspark.sql.tests.test_python_datasource'] python3 python_implementation is CPython python3 version is: Python 3.14.0 Starting test(python3): pyspark.sql.tests.test_python_datasource (temp output: /Users/dongjoon/APACHE/spark-merge/python/target/e771105c-5304-4f4f-bea6-b8d896b1b250/python3__pyspark.sql.tests.test_python_datasource__2wyrv5n4.log) Finished test(python3): pyspark.sql.tests.test_python_datasource (29s) Tests passed in 29 seconds ``` ### Does this PR introduce _any_ user-facing change? No. This is a test change. ### How was this patch tested? Pass the CIs and manual tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52967 from dongjoon-hyun/SPARK-54065. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
that referenced
this pull request
Nov 10, 2025
…ython 3.14 ### What changes were proposed in this pull request? This PR aims to enable `test_in_memory_data_source` in Python 3.14. ### Why are the changes needed? After upgrading to the latest `cloudpickle` 3.1.2, I verified that the test passed on Python 3.14.0. - #52964 ``` $ python/run-tests --parallelism 1 --testnames pyspark.sql.tests.test_python_datasource --python-executables python3 Running PySpark tests. Output is in /Users/dongjoon/APACHE/spark-merge/python/unit-tests.log Will test against the following Python executables: ['python3'] Will test the following Python tests: ['pyspark.sql.tests.test_python_datasource'] python3 python_implementation is CPython python3 version is: Python 3.14.0 Starting test(python3): pyspark.sql.tests.test_python_datasource (temp output: /Users/dongjoon/APACHE/spark-merge/python/target/e771105c-5304-4f4f-bea6-b8d896b1b250/python3__pyspark.sql.tests.test_python_datasource__2wyrv5n4.log) Finished test(python3): pyspark.sql.tests.test_python_datasource (29s) Tests passed in 29 seconds ``` ### Does this PR introduce _any_ user-facing change? No. This is a test change. ### How was this patch tested? Pass the CIs and manual tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52967 from dongjoon-hyun/SPARK-54065. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 79d0c42) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to upgrade
cloudpickleto 3.1.2.Why are the changes needed?
To support Python 3.14 properly.
https://github.com/cloudpipe/cloudpickle/releases/tag/v3.1.2
https://github.com/cloudpipe/cloudpickle/blob/master/CHANGES.md#312
Does this PR introduce any user-facing change?
No, Python 3.14 support is not announced yet.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.