-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-53974][BUILD] Bump Jackson 2.20.0 #52687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
peter-toth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending CI.
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM (Pending CIs). Thank you, @pan3793 and Peter.
|
It will be good to test these change with Kinesis ASL. Upgrade to incompatible version of Jackson is what caused https://issues.apache.org/jira/browse/SPARK-53927 on 4.x |
|
@vrozov I don't have an AWS account to access Kinesis, is it possible to test with something like localstack? or API compatible service, e.g. MinIO for S3 |
|
@pan3793 IDK if something like MinIO is an option. I used actual Kinesis service to test https://issues.apache.org/jira/browse/SPARK-53927. I can try to test your PR using my Kinesis tomorrow. |
sarutak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pan3793
I confirmed Kinesis tests pass with this change on my dev environment.
I'll merge this into master.
Thank you all!
|
@sarutak, thank you for checking Kinesis tests |
What changes were proposed in this pull request?
Jackson 2.20 was released on August 28, 2025.
Release Notes: https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.20
Release Blog: https://cowtowncoder.medium.com/jackson-2-20-0-released-0cc58ed1ea9f
Why are the changes needed?
Bump Jackson to the latest 2.x version, Jackson 3.0.0 has been released in October, 2.20 probably is the last feature version of 2.x serials?
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GHA.
Was this patch authored or co-authored using generative AI tooling?
No.