[SPARK-53277][INFRA] Improve merge_spark_pr.py to stop early in case of the closed PRs
#52019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of the closed PRs
Member
Author
|
cc @yaooqinn |
HyukjinKwon
approved these changes
Aug 14, 2025
Member
Author
|
Thank you again, @HyukjinKwon . Merged to master. |
Member
|
Merging closed PR is a valid case for backporting https://github.com/apache/spark/blob/master/dev/merge_spark_pr.py#L687 |
Member
Author
|
Oh, sorry for missing that. I reverted this PR. Thank you, @yaooqinn . |
Member
|
Thank you for reverting @dongjoon-hyun |
mzhang
pushed a commit
to mzhang/spark
that referenced
this pull request
Aug 21, 2025
…e of the closed PRs ### What changes were proposed in this pull request? This PR aims to improve `merge_spark_pr.py` to stop early in case of the closed PRs. ### Why are the changes needed? To help committers by removing the useless interactions. **BEFORE** ``` $ dev/merge_spark_pr.py git rev-parse --abbrev-ref HEAD Which pull request would you like to merge? (e.g. 34): 1 I've re-written the title as follows to match the standard format: Original: Removed reference to incubation in README.md. Modified: Removed reference to incubation in README.md Would you like to use the modified title? (y/N): ... ``` **AFTER** ``` $ dev/merge_spark_pr.py git rev-parse --abbrev-ref HEAD Which pull request would you like to merge? (e.g. 34): 1 apache#1 is closed already. Restoring head pointer to SPARK-53277 git checkout SPARK-53277 Already on 'SPARK-53277' git branch ``` ### Does this PR introduce _any_ user-facing change? No, this is used by committers only. ### How was this patch tested? Manually check. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52019 from dongjoon-hyun/SPARK-53277. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to improve
merge_spark_pr.pyto stop early in case of the closed PRs.Why are the changes needed?
To help committers by removing the useless interactions.
BEFORE
AFTER
Does this PR introduce any user-facing change?
No, this is used by committers only.
How was this patch tested?
Manually check.
Was this patch authored or co-authored using generative AI tooling?
No.