[SPARK-53180][CORE] Use Java InputStream.skipNBytes instead of ByteStreams.skipFully
#51909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eStreams.skipFully`
Member
Author
|
Could you review this too when you have some time, @peter-toth ? |
peter-toth
approved these changes
Aug 7, 2025
Member
Author
|
Thank you, @peter-toth ! |
Member
Author
|
Merged to master for Apache Spark 4.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to use Java
InputStream.skipNBytesinstead ofByteStreams.skipFully.Why are the changes needed?
Java 12+ supports
skipNBytesnatively. We had better use this simple style.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.