Skip to content

[SPARK-53168][CORE][TESTS] Change default value of the input parameter level for SparkFunSuite#withLogAppender from None to Some(Level.INFO) #51895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[SPARK-53168][CORE][TESTS] Change default value of the input parameter level for SparkFunSuite#withLogAppender from None to Some(Level.INFO) #51895

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2dc5e7
init
LuciferYang Aug 7, 2025
bc49c35
Revert "init"
LuciferYang Aug 7, 2025
4f3269c
None to Some(Level.INFO)
LuciferYang Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/test/scala/org/apache/spark/SparkFunSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ abstract class SparkFunSuite
protected def withLogAppender(
appender: AbstractAppender,
loggerNames: Seq[String] = Seq.empty,
level: Option[Level] = None)(
level: Option[Level] = Some(Level.INFO))(
Copy link
Contributor Author

@LuciferYang LuciferYang Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check if there are any related test cases that need to be specified with a different log level.

f: => Unit): Unit = {
val loggers = if (loggerNames.nonEmpty) {
loggerNames.map(LogManager.getLogger)
Expand Down