[SPARK-53045][SQL] DESCRIBE EXTENDED should be resilient to corrupt metadata #51753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szehon-ho
force-pushed
the
view_query_output_cols
branch
from
705ec6a to
2dbd5e3
Compare
cloud-fan
reviewed
Aug 1, 2025
| import org.apache.spark.sql.connector.catalog.CatalogV2Implicits._ | ||
| map += "View Catalog and Namespace" -> JString(viewCatalogAndNamespaceInfos.quoted) | ||
| } | ||
| val viewQueryOutputColumns: JValue = Try { |
Contributor
There was a problem hiding this comment.
can we use standard try-catch and swallow NonFatal errors?
Member
Author
There was a problem hiding this comment.
hm, doesn't Try do that (catch only NonFatal, ie https://github.com/scala/scala/blob/v2.13.2/src/library/scala/util/Try.scala#L204) not sure i miss something
cloud-fan
approved these changes
Aug 1, 2025
peter-toth
approved these changes
Aug 4, 2025
Contributor
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
A lot of methods called by DESCRIBE EXTENDED can throw exception if the CatalotTable metadata is not a certain way, in particular in the case of view which has strict requirements.
This proposes to make DESCRIBE EXTENDED and CatalogTable.toString still able to return successfully in this case.
Why are the changes needed?
We see some issue where somehow there is some leftover View metadata on a table, and DESC EXTENDED and jobs attempting to call toString on the table both crash, even if the table is not a view
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing unit test
Was this patch authored or co-authored using generative AI tooling?
No