[MINOR][CORE][TESTS] Remove a redundant @VisibleForTesting in test code #51744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
requested changes
Jul 31, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you for making a PR, @zhztheplayer .
However, the annotation is proper and correct.
This annotation is supposed to help a developer understand the reason why this is public instead of protected when TestMemoryConsumer extends MemoryConsumer.
Member
Author
|
Hi @dongjoon-hyun, Thank you for your insights! Just thought the annotation was unintentionally added, as it's a little bit counter-intuitive because it appears in test code. I just found some discussion about this flag in #21570 also. Since it means there was a reason from the author, I will be good to keep it. :) |
Member
|
Thank you for closing your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove a redundant @VisibleForTesting on test code
TestMemoryConsumer#freePage(added in #21570).Why are the changes needed?
Test code doesn't need this annotation.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.