[SPARK-51555][SQL] Add the time_diff() function #51715
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uros-db
changed the title
uros-db
commented
Jul 30, 2025
Contributor
Author
uros-db
left a comment
uros-db
left a comment
There was a problem hiding this comment.
@cloud-fan Please review.
cloud-fan
reviewed
Jul 30, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
Show resolved
Hide resolved
cloud-fan
approved these changes
Jul 30, 2025
Contributor
|
thanks, merging to master! |
cloud-fan
pushed a commit
that referenced
this pull request
Aug 4, 2025
…n the time_diff() function ### What changes were proposed in this pull request? Following up on the original PR that introduces the `time_diff` function (#51715), this PR fixes the error message to include the correct SQL function name. ### Why are the changes needed? Fix error messages for the `time_diff` function. ### Does this PR introduce _any_ user-facing change? Changes the error message for the new SQL function. ### How was this patch tested? Updated relevant scala tests and golden files. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #51777 from uros-db/time_diff_FOLLOWUP. Authored-by: Uros Bojanic <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implement the
time_difffunction, which returns the difference between two times measured in units.Syntax
Arguments
unit: A unit of measure.start: A starting TIME expression.end: An ending TIME expression.Returns
An INTEGER.
If start is greater than end the result is negative.
Why are the changes needed?
Users will be able to calculate time difference in specified units.
Does this PR introduce any user-facing change?
Yes, this PR introduces a new expression.
How was this patch tested?
New unit tests for time truncation, catalyst expression level unit tests with & without codegen, e2e SQL tests / golden files in both ANSI and non-ANSI modes.
Was this patch authored or co-authored using generative AI tooling?
No.