Skip to content

[SPARK-6512] add contains to OpenHashMap #5171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-6512] add contains to OpenHashMap #5171

wants to merge 2 commits into from

Conversation

@mengxr
Copy link
Contributor

@mengxr mengxr commented Mar 24, 2015

Add contains to test whether a key exists in an OpenHashMap. @rxin

@SparkQA
Copy link

SparkQA commented Mar 24, 2015

Test build #29103 has started for PR 5171 at commit 748a69b.

  • This patch merges cleanly.

rxin
rxin reviewed Mar 24, 2015
View reviewed changes
core/src/main/scala/org/apache/spark/util/collection/OpenHashMap.scala Outdated
Copy link
Contributor

@rxin rxin Mar 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the contract is getPos(k) != INVALID_POS

@SparkQA
Copy link

SparkQA commented Mar 24, 2015

Test build #29103 has finished for PR 5171 at commit 748a69b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 24, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29103/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Mar 24, 2015

Test build #29113 has started for PR 5171 at commit d6e6f1f.

  • This patch merges cleanly.

@mengxr mengxr mentioned this pull request Mar 24, 2015
Closed
1 task
@SparkQA
Copy link

SparkQA commented Mar 24, 2015

Test build #29113 has finished for PR 5171 at commit d6e6f1f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 24, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29113/
Test PASSed.

@rxin
Copy link
Contributor

rxin commented Mar 24, 2015

lgtm

@mengxr
Copy link
Contributor Author

mengxr commented Mar 25, 2015

Merged into master.

@asfgit asfgit closed this in 6930e96 Mar 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mengxr @SparkQA @AmplabJenkins @rxin