[SPARK-6455] [docs] Correct some mistakes and typos #5128
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Member
|
LGTM. Just trivial doc fixes and so I don't think they even deserve a Jenkins test (which is having a bit of trouble at the moment.) I verified that the example comment is now correct. |
Contributor
|
Sean this broke the build! |
asfgit
pushed a commit
that referenced
this pull request
Mar 22, 2015
Contributor
|
I fixed the build here : 7a0da47 |
Member
|
Ah! of course the line length now fails the style check; it didn't line-break. Well that'll teach me to eye-ball even a trivial doc change. Very sorry about that and thank you for the fix. Just waiting for Jenkins to come back would probably have been smarter, but running the style check locally was also an option, to double-check. I should have at least done that. |
Author
|
Thank you for the fix! I forgot to check the length. I'll pay attention to it in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct some typos. Correct a mistake in lib/PageRank.scala. The first PageRank implementation uses standalone Graph interface, but the second uses Pregel interface. It may mislead the code viewers.