[SPARK-52181][SQL][FOLLOWUP] Avoid OOM in variant tests #50950
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
LuciferYang
approved these changes
May 20, 2025
Contributor
LuciferYang
left a comment
LuciferYang
left a comment
There was a problem hiding this comment.
+1, LGTM (pending tests)
Contributor
|
All test passed, I will merge this one to restore GA first |
Contributor
|
Merged into master. Thanks @cloud-fan |
cloud-fan
added a commit
to cloud-fan/spark
that referenced
this pull request
May 20, 2025
This is a follow-up of apache#50913 . It sets the variant size limit back to 16 MB in test environment, to reduce OOM in tests. make tests more reliable. no existing tests no Closes apache#50950 from cloud-fan/test. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: yangjie01 <[email protected]>
cloud-fan
added a commit
that referenced
this pull request
May 20, 2025
This is a 4.0 backport of #50950 ### What changes were proposed in this pull request? This is a follow-up of #50913 . It sets the variant size limit back to 16 MB in test environment, to reduce OOM in tests. ### Why are the changes needed? make tests more reliable. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests ### Was this patch authored or co-authored using generative AI tooling? no Closes #50954 from cloud-fan/test. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
yhuang-db
pushed a commit
to yhuang-db/spark
that referenced
this pull request
Jun 9, 2025
### What changes were proposed in this pull request? This is a follow-up of apache#50913 . It sets the variant size limit back to 16 MB in test environment, to reduce OOM in tests. ### Why are the changes needed? make tests more reliable. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#50950 from cloud-fan/test. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: yangjie01 <[email protected]>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
This is a 4.0 backport of apache#50950 ### What changes were proposed in this pull request? This is a follow-up of apache#50913 . It sets the variant size limit back to 16 MB in test environment, to reduce OOM in tests. ### Why are the changes needed? make tests more reliable. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#50954 from cloud-fan/test. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of #50913 . It sets the variant size limit back to 16 MB in test environment, to reduce OOM in tests.
Why are the changes needed?
make tests more reliable.
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests
Was this patch authored or co-authored using generative AI tooling?
no