[SPARK-52181][4.0] Increase variant size limit to 128MiB #50927
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase variant size limit from 16MiB to 128MiB. It is difficult to control the size limit with a flag, because the limit is accessed in many places where the SQL config is not available (e.g., `VariantVal.toString`). Future memory instability is possible, but this change won't break any existing workload. It enhances the ability of the variant data type to process larger data. Yes, as stated above. Unit test. No. Closes apache#50913 from chenhao-db/variant_large_size_limit. Lead-authored-by: Chenhao Li <[email protected]> Co-authored-by: Wenchen Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Contributor
Author
|
@cloud-fan This is the backport to 4.0. Thanks! |
Contributor
|
The failed test is unrelated to this PR and has been fixed by #50928 |
Contributor
|
thanks, merging to 4.0! |
cloud-fan
pushed a commit
that referenced
this pull request
May 17, 2025
### What changes were proposed in this pull request? This is a cherry-pick of #50913 Increase variant size limit from 16MiB to 128MiB. It is difficult to control the size limit with a flag, because the limit is accessed in many places where the SQL config is not available (e.g., `VariantVal.toString`). Future memory instability is possible, but this change won't break any existing workload. ### Why are the changes needed? It enhances the ability of the variant data type to process larger data. ### Does this PR introduce _any_ user-facing change? Yes, as stated above. ### How was this patch tested? Unit test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #50927 from chenhao-db/variant_large_size_limit_4.0. Authored-by: Chenhao Li <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a cherry-pick of #50913
Increase variant size limit from 16MiB to 128MiB. It is difficult to control the size limit with a flag, because the limit is accessed in many places where the SQL config is not available (e.g.,
VariantVal.toString). Future memory instability is possible, but this change won't break any existing workload.Why are the changes needed?
It enhances the ability of the variant data type to process larger data.
Does this PR introduce any user-facing change?
Yes, as stated above.
How was this patch tested?
Unit test.
Was this patch authored or co-authored using generative AI tooling?
No.