[SPARK-52052][CORE] Add .broadcast in the companion object of SerializableConfiguration
#50844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zableConfiguration
Member
Author
|
cc @dongjoon-hyun, thank you in advance |
| } | ||
| } | ||
|
|
||
| private[spark] object SerializableConfiguration { |
dongjoon-hyun
changed the title
.broadcast in the companion object of SerializableConfiguration
dongjoon-hyun
approved these changes
May 9, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Merged to master.
Thank you, @yaooqinn .
szehon-ho
reviewed
May 13, 2025
| options: Map[String, String], | ||
| hadoopConf: Configuration): PartitionedFile => Iterator[InternalRow] = { | ||
| val broadcastedHadoopConf = | ||
| SerializableConfiguration.broadcast(sparkSession.sparkContext, hadoopConf) |
Member
There was a problem hiding this comment.
@yaooqinn @dongjoon-hyun i wonder if the next line can be removed (as its return value is no longer used, so looks like its a wasted side-effect)? I made a pr for it: #50874 , can you check if it makes sense?
HyukjinKwon
pushed a commit
that referenced
this pull request
May 15, 2025
### What changes were proposed in this pull request? Remove an extra broadcast added in #50844 ### Why are the changes needed? Return value of broadcast is not used, so it seems it is not needed ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing tests ### Was this patch authored or co-authored using generative AI tooling? No Closes #50874 from szehon-ho/SPARK-52052-follow. Authored-by: Szehon Ho <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
yhuang-db
pushed a commit
to yhuang-db/spark
that referenced
this pull request
Jun 9, 2025
…alizableConfiguration` ### What changes were proposed in this pull request? Add .broadcast in the companion object of SerializableConfiguration ### Why are the changes needed? - Simplify broadcast logic for SerializableConfiguration - Reduce SparkContext API usage across non-core modules - Bypass IDE type inference issue ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? Pass GA ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#50844 from yaooqinn/SPARK-52052. Authored-by: Kent Yao <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
yhuang-db
pushed a commit
to yhuang-db/spark
that referenced
this pull request
Jun 9, 2025
### What changes were proposed in this pull request? Remove an extra broadcast added in apache#50844 ### Why are the changes needed? Return value of broadcast is not used, so it seems it is not needed ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing tests ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#50874 from szehon-ho/SPARK-52052-follow. Authored-by: Szehon Ho <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add .broadcast in the companion object of SerializableConfiguration
Why are the changes needed?
Does this PR introduce any user-facing change?
no
How was this patch tested?
Pass GA
Was this patch authored or co-authored using generative AI tooling?
no