-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-6313] Add config option to disable file locks/fetchFile cache to ... #5036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…to support NFS mounts
|
Can one of the admins verify this patch? |
|
Jenkins, this is ok to test. |
|
Test build #28652 has started for PR 5036 at commit
|
|
Refer to this link for build results (access rights to CI server needed): |
|
jenkins, test this please |
|
Test build #28655 has started for PR 5036 at commit
|
|
Test build #28655 has finished for PR 5036 at commit
|
|
Test PASSed. |
|
As a workaround for the NFS issue, this looks good to me. I have a couple of minor grammar / documentation nits, which I'll comment on below, but I can fix those up myself on merge if you don't get around to it first. |
docs/configuration.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd reword this slightly in order to match the style of similar boolean options. How about this:
If set to true (default), file fetching will use a local cache that is shared by executors that belong to the same application, which can improve task launching performance when running many executors on the same host. If set to false, these caching optimizations will be disabled and all executors will fetch their own copies of files. This optimization may be disabled in order to use Spark local directories that reside on NFS filesystems (see SPARK-6313 for more details).
|
@JoshRosen Thanks for the feedback. Updated as suggested. |
|
Test build #28682 has started for PR 5036 at commit
|
|
Test build #28682 has finished for PR 5036 at commit
|
|
Test PASSed. |
|
LGTM, so I'm going to merge this into |
…to ... ...support NFS mounts. This is a work around for now with the goal to find a more permanent solution. https://issues.apache.org/jira/browse/SPARK-6313 Author: nemccarthy <[email protected]> Closes #5036 from nemccarthy/master and squashes the following commits: 2eaaf42 [nemccarthy] [SPARK-6313] Update config wording doc for spark.files.useFetchCache 5de7eb4 [nemccarthy] [SPARK-6313] Add config option to disable file locks/fetchFile cache to support NFS mounts (cherry picked from commit 4cca391) Signed-off-by: Josh Rosen <[email protected]>
…to ... ...support NFS mounts. This is a work around for now with the goal to find a more permanent solution. https://issues.apache.org/jira/browse/SPARK-6313 Author: nemccarthy <[email protected]> Closes #5036 from nemccarthy/master and squashes the following commits: 2eaaf42 [nemccarthy] [SPARK-6313] Update config wording doc for spark.files.useFetchCache 5de7eb4 [nemccarthy] [SPARK-6313] Add config option to disable file locks/fetchFile cache to support NFS mounts (cherry picked from commit 4cca391) Signed-off-by: Josh Rosen <[email protected]>
...support NFS mounts.
This is a work around for now with the goal to find a more permanent solution.
https://issues.apache.org/jira/browse/SPARK-6313