Skip to content

Conversation

@nemccarthy
Copy link
Contributor

...support NFS mounts.

This is a work around for now with the goal to find a more permanent solution.
https://issues.apache.org/jira/browse/SPARK-6313

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@JoshRosen
Copy link
Contributor

Jenkins, this is ok to test.

@SparkQA
Copy link

SparkQA commented Mar 16, 2015

Test build #28652 has started for PR 5036 at commit 5de7eb4.

  • This patch merges cleanly.

@AmplabJenkins
Copy link

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28652/
Test FAILed.

@shaneknapp
Copy link
Contributor

jenkins, test this please

@SparkQA
Copy link

SparkQA commented Mar 16, 2015

Test build #28655 has started for PR 5036 at commit 5de7eb4.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 16, 2015

Test build #28655 has finished for PR 5036 at commit 5de7eb4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28655/
Test PASSed.

@JoshRosen
Copy link
Contributor

As a workaround for the NFS issue, this looks good to me. I have a couple of minor grammar / documentation nits, which I'll comment on below, but I can fix those up myself on merge if you don't get around to it first.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd reword this slightly in order to match the style of similar boolean options. How about this:

If set to true (default), file fetching will use a local cache that is shared by executors that belong to the same application, which can improve task launching performance when running many executors on the same host. If set to false, these caching optimizations will be disabled and all executors will fetch their own copies of files. This optimization may be disabled in order to use Spark local directories that reside on NFS filesystems (see SPARK-6313 for more details).

@nemccarthy
Copy link
Contributor Author

@JoshRosen Thanks for the feedback. Updated as suggested.

@SparkQA
Copy link

SparkQA commented Mar 16, 2015

Test build #28682 has started for PR 5036 at commit 2eaaf42.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 17, 2015

Test build #28682 has finished for PR 5036 at commit 2eaaf42.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28682/
Test PASSed.

@JoshRosen
Copy link
Contributor

LGTM, so I'm going to merge this into master (1.4.0), branch-1.3 (1.3.1), and branch-1.2 (1.2.2) (since this cache was first introduced in 1.2.0).

asfgit pushed a commit that referenced this pull request Mar 17, 2015
…to ...

...support NFS mounts.

This is a work around for now with the goal to find a more permanent solution.
https://issues.apache.org/jira/browse/SPARK-6313

Author: nemccarthy <[email protected]>

Closes #5036 from nemccarthy/master and squashes the following commits:

2eaaf42 [nemccarthy] [SPARK-6313] Update config wording doc for spark.files.useFetchCache
5de7eb4 [nemccarthy] [SPARK-6313] Add config option to disable file locks/fetchFile cache to support NFS mounts

(cherry picked from commit 4cca391)
Signed-off-by: Josh Rosen <[email protected]>
asfgit pushed a commit that referenced this pull request Mar 17, 2015
…to ...

...support NFS mounts.

This is a work around for now with the goal to find a more permanent solution.
https://issues.apache.org/jira/browse/SPARK-6313

Author: nemccarthy <[email protected]>

Closes #5036 from nemccarthy/master and squashes the following commits:

2eaaf42 [nemccarthy] [SPARK-6313] Update config wording doc for spark.files.useFetchCache
5de7eb4 [nemccarthy] [SPARK-6313] Add config option to disable file locks/fetchFile cache to support NFS mounts

(cherry picked from commit 4cca391)
Signed-off-by: Josh Rosen <[email protected]>
@asfgit asfgit closed this in 4cca391 Mar 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants