[SPARK-47241][SQL][FOLLOWUP] Fix issue when laterally referencing a Generator
#50310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihailotim-db
force-pushed
the
mihailotim-db/generator_lca
branch
4 times, most recently
from
bc0c013 to
70c6828
Compare
mihailotim-db
force-pushed
the
mihailotim-db/generator_lca
branch
from
70c6828 to
5ab688f
Compare
mihailotim-db
commented
Mar 19, 2025
| sql("select 1 as a, a").queryExecution.assertAnalyzed() | ||
| } | ||
|
|
||
| test("SPARK-49349: Improve error message for LCA with Generate") { |
Contributor
Author
There was a problem hiding this comment.
This test now passes so refactoring it a bit
Contributor
|
This is a partial revert of #45350 . I don't quite like this fix, but seems this is the only way to fix the conflicts between two rules.
Now we relax the trigger condition of rule |
Contributor
|
thanks, merging to master/4.0/3.5! |
cloud-fan
pushed a commit
that referenced
this pull request
Mar 20, 2025
…Generator` ### What changes were proposed in this pull request? Fix issue when laterally referencing a `Generator`. ### Why are the changes needed? Fix the following query pattern: ``` WITH cte AS (SELECT EXPLODE(ARRAY(1, 2, 3)) AS c1, c1) SELECT * FROM cte ``` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added a test case to `LateralColumnAliasSuite` ### Was this patch authored or co-authored using generative AI tooling? No Closes #50310 from mihailotim-db/mihailotim-db/generator_lca. Authored-by: Mihailo Timotic <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 62c0669) Signed-off-by: Wenchen Fan <[email protected]>
cloud-fan
pushed a commit
that referenced
this pull request
Mar 20, 2025
…Generator` Fix issue when laterally referencing a `Generator`. Fix the following query pattern: ``` WITH cte AS (SELECT EXPLODE(ARRAY(1, 2, 3)) AS c1, c1) SELECT * FROM cte ``` No Added a test case to `LateralColumnAliasSuite` No Closes #50310 from mihailotim-db/mihailotim-db/generator_lca. Authored-by: Mihailo Timotic <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 62c0669) Signed-off-by: Wenchen Fan <[email protected]>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
…Generator` ### What changes were proposed in this pull request? Fix issue when laterally referencing a `Generator`. ### Why are the changes needed? Fix the following query pattern: ``` WITH cte AS (SELECT EXPLODE(ARRAY(1, 2, 3)) AS c1, c1) SELECT * FROM cte ``` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added a test case to `LateralColumnAliasSuite` ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#50310 from mihailotim-db/mihailotim-db/generator_lca. Authored-by: Mihailo Timotic <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 3fb6549) Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix issue when laterally referencing a
Generator.Why are the changes needed?
Fix the following query pattern:
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added a test case to
LateralColumnAliasSuiteWas this patch authored or co-authored using generative AI tooling?
No