[SPARK-51307][SQL][3.5] locationUri in CatalogStorageFormat shall be decoded for display #50164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…decoded for display
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you for making a backporting PR.
Member
|
Sorry but could you rebase once more because Docker and SparkR CI also failed before, @yaooqinn ? 
|
Member
Author
|
Thank you @dongjoon-hyun |
yaooqinn
added a commit
that referenced
this pull request
Mar 6, 2025
…decoded for display ### What changes were proposed in this pull request? This PR uses CatalogUtils.URIToString instead of URI.toString to decode the location URI. ### Why are the changes needed? For example, for partition specs like test1=X'16', test3=timestamp'2018-11-17 13:33:33', the stored path will include them as `test1=%16/test3=2018-11-17 13%3A33%3A33` because the special characters are escaped. Furthermore, while resolving the whole path string to a URI object, this path fragment becomes `test1=%2516/test3=2018-11-17 13%253A33%253A33`, so we need to decode `%25` -> `%` before displaying to users ### Does this PR introduce _any_ user-facing change? yes, DESC TABLE will not show 2x-encoded paths. ### How was this patch tested? new tests ### Was this patch authored or co-authored using generative AI tooling? no Closes #50164 from yaooqinn/SPARK-51307-35. Authored-by: Kent Yao <[email protected]> Signed-off-by: Kent Yao <[email protected]>
Member
Author
|
Merged to branch 3.5, thank you again @dongjoon-hyun |
jetoile
pushed a commit
to criteo-forks/spark
that referenced
this pull request
Jul 15, 2025
…decoded for display ### What changes were proposed in this pull request? This PR uses CatalogUtils.URIToString instead of URI.toString to decode the location URI. ### Why are the changes needed? For example, for partition specs like test1=X'16', test3=timestamp'2018-11-17 13:33:33', the stored path will include them as `test1=%16/test3=2018-11-17 13%3A33%3A33` because the special characters are escaped. Furthermore, while resolving the whole path string to a URI object, this path fragment becomes `test1=%2516/test3=2018-11-17 13%253A33%253A33`, so we need to decode `%25` -> `%` before displaying to users ### Does this PR introduce _any_ user-facing change? yes, DESC TABLE will not show 2x-encoded paths. ### How was this patch tested? new tests ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#50164 from yaooqinn/SPARK-51307-35. Authored-by: Kent Yao <[email protected]> Signed-off-by: Kent Yao <[email protected]>
turboFei
pushed a commit
to turboFei/spark
that referenced
this pull request
Nov 6, 2025
…ed for display (apache#728) [SPARK-51307][SQL][3.5] locationUri in CatalogStorageFormat shall be decoded for display ### What changes were proposed in this pull request? This PR uses CatalogUtils.URIToString instead of URI.toString to decode the location URI. ### Why are the changes needed? For example, for partition specs like test1=X'16', test3=timestamp'2018-11-17 13:33:33', the stored path will include them as `test1=%16/test3=2018-11-17 13%3A33%3A33` because the special characters are escaped. Furthermore, while resolving the whole path string to a URI object, this path fragment becomes `test1=%2516/test3=2018-11-17 13%253A33%253A33`, so we need to decode `%25` -> `%` before displaying to users ### Does this PR introduce _any_ user-facing change? yes, DESC TABLE will not show 2x-encoded paths. ### How was this patch tested? new tests ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#50164 from yaooqinn/SPARK-51307-35. Authored-by: Kent Yao <[email protected]> Signed-off-by: Kent Yao <[email protected]> Co-authored-by: Kent Yao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR uses CatalogUtils.URIToString instead of URI.toString to decode the location URI.
Why are the changes needed?
For example, for partition specs like test1=X'16', test3=timestamp'2018-11-17 13:33:33', the stored path will include them as
test1=%16/test3=2018-11-17 13%3A33%3A33because the special characters are escaped. Furthermore, while resolving the whole path string to a URI object, this path fragment becomestest1=%2516/test3=2018-11-17 13%253A33%253A33, so we need to decode%25->%before displaying to usersDoes this PR introduce any user-facing change?
yes, DESC TABLE will not show 2x-encoded paths.
How was this patch tested?
new tests
Was this patch authored or co-authored using generative AI tooling?
no