Skip to content

Conversation

@davies
Copy link
Contributor

@davies davies commented Mar 12, 2015

The Thread.interrupt() can not terminate the thread in some cases, so we should not wait for the writerThread of PythonRDD.

This PR also ignore some exception during clean up.

cc @mengxr

@SparkQA
Copy link

SparkQA commented Mar 12, 2015

Test build #28520 has started for PR 5003 at commit 2f2f893.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 12, 2015

Test build #28520 has finished for PR 5003 at commit 2f2f893.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28520/
Test PASSed.

asfgit pushed a commit that referenced this pull request Mar 12, 2015
The Thread.interrupt() can not terminate the thread in some cases, so we should not wait for the writerThread of PythonRDD.

This PR also ignore some exception during clean up.

cc mengxr

Author: Davies Liu <[email protected]>

Closes #5003 from davies/fix_take2 and squashes the following commits:

2f2f893 [Davies Liu] fix take of PythonRDD in JVM
@mengxr
Copy link
Contributor

mengxr commented Mar 12, 2015

LGTM. Merged into branch-1.2.

@davies
Copy link
Contributor Author

davies commented Mar 12, 2015

merged.

@davies davies closed this Mar 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants